From: Michael Tokarev <mjt@tls.msk.ru>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: peter.maydell@linaro.org, qemu-trivial <qemu-trivial@nongnu.org>,
qemu-devel@nongnu.org, dgilbert@redhat.com, edgari@xilinx.com,
mkletzan@redhat.com
Subject: Re: [Qemu-trivial] [PATCH bugfix v1 1/1] char/serial: Fix emptyness check
Date: Tue, 11 Feb 2014 14:29:28 +0400 [thread overview]
Message-ID: <52F9FB88.1050509@msgid.tls.msk.ru> (raw)
In-Reply-To: <153a8e98437c7d4b7fc3df2bf375fbc9e0bdb8ef.1392101145.git.peter.crosthwaite@xilinx.com>
11.02.2014 10:49, Peter Crosthwaite wrote:
> This was guarding against a full fifo rather than an empty fifo when
> popping. Fix.
I've applied this to qemu-trivial for now, if no one will pick it up
before the next -trivial pull, -- because the original change were
merged using -trivial too.
I also compared this with the previous code in this area, and it looks
like this is the right fix. So you can add my
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
too.
Thank you!
/mjt
WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: peter.maydell@linaro.org, qemu-trivial <qemu-trivial@nongnu.org>,
qemu-devel@nongnu.org, dgilbert@redhat.com, edgari@xilinx.com,
mkletzan@redhat.com
Subject: Re: [Qemu-devel] [PATCH bugfix v1 1/1] char/serial: Fix emptyness check
Date: Tue, 11 Feb 2014 14:29:28 +0400 [thread overview]
Message-ID: <52F9FB88.1050509@msgid.tls.msk.ru> (raw)
In-Reply-To: <153a8e98437c7d4b7fc3df2bf375fbc9e0bdb8ef.1392101145.git.peter.crosthwaite@xilinx.com>
11.02.2014 10:49, Peter Crosthwaite wrote:
> This was guarding against a full fifo rather than an empty fifo when
> popping. Fix.
I've applied this to qemu-trivial for now, if no one will pick it up
before the next -trivial pull, -- because the original change were
merged using -trivial too.
I also compared this with the previous code in this area, and it looks
like this is the right fix. So you can add my
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
too.
Thank you!
/mjt
next prev parent reply other threads:[~2014-02-11 10:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 6:49 [Qemu-devel] [PATCH bugfix v1 1/1] char/serial: Fix emptyness check Peter Crosthwaite
2014-02-11 9:55 ` Dr. David Alan Gilbert
2014-02-11 12:38 ` [Qemu-devel] [PATCH bugfix v1 1/1] char/serial: Fix emptynesscheckk Alex Bennée
2014-02-11 12:41 ` Dr. David Alan Gilbert
2014-02-11 10:25 ` [Qemu-devel] [PATCH bugfix v1 1/1] char/serial: Fix emptyness check Martin Kletzander
2014-02-11 10:29 ` Michael Tokarev [this message]
2014-02-11 10:29 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F9FB88.1050509@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=dgilbert@redhat.com \
--cc=edgari@xilinx.com \
--cc=mkletzan@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.