All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Dmitry Fleytman <dmitry@daynix.com>,
	qemu-trivial <qemu-trivial@nongnu.org>,
	Alexander Graf <agraf@suse.de>,
	Anthony Liguori <aliguori@amazon.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] net: Include iov.h in checksum.h
Date: Tue, 11 Feb 2014 14:30:06 +0400	[thread overview]
Message-ID: <52F9FBAE.50503@msgid.tls.msk.ru> (raw)
In-Reply-To: <20140210102034.GA15227@stefanha-thinkpad.brq.redhat.com>

10.02.2014 14:20, Stefan Hajnoczi пишет:
> On Fri, Feb 07, 2014 at 08:54:00AM +0100, Alexander Graf wrote:
>>
>>
>>> Am 07.02.2014 um 08:05 schrieb Michael Tokarev <mjt@tls.msk.ru>:
>>>
>>> 06.02.2014 19:30, Alexander Graf wrote:
>>>> The checksum calculation header exports a function that refers to struct
>>>> iov which is defined in iov.h. Include the header so that the compiler
>>>> knows what this struct is about.
>>>
>>> Alternatively (and I sometimes prefer it this way), one can just
>>> declare `struct iovec;' instead of including whole header, because
>>> we don't actually use any definitions from there, and users of
>>> checksum.h wont be including extra dependencies which they don't
>>> use...  Like this:
>>
>> Either way works for me :)
> 
> Yes, please take one of them via -trivial.

I've applied my version to -trivial.

Thanks,

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Dmitry Fleytman <dmitry@daynix.com>,
	qemu-trivial <qemu-trivial@nongnu.org>,
	Alexander Graf <agraf@suse.de>,
	Anthony Liguori <aliguori@amazon.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] net: Include iov.h in checksum.h
Date: Tue, 11 Feb 2014 14:30:06 +0400	[thread overview]
Message-ID: <52F9FBAE.50503@msgid.tls.msk.ru> (raw)
In-Reply-To: <20140210102034.GA15227@stefanha-thinkpad.brq.redhat.com>

10.02.2014 14:20, Stefan Hajnoczi пишет:
> On Fri, Feb 07, 2014 at 08:54:00AM +0100, Alexander Graf wrote:
>>
>>
>>> Am 07.02.2014 um 08:05 schrieb Michael Tokarev <mjt@tls.msk.ru>:
>>>
>>> 06.02.2014 19:30, Alexander Graf wrote:
>>>> The checksum calculation header exports a function that refers to struct
>>>> iov which is defined in iov.h. Include the header so that the compiler
>>>> knows what this struct is about.
>>>
>>> Alternatively (and I sometimes prefer it this way), one can just
>>> declare `struct iovec;' instead of including whole header, because
>>> we don't actually use any definitions from there, and users of
>>> checksum.h wont be including extra dependencies which they don't
>>> use...  Like this:
>>
>> Either way works for me :)
> 
> Yes, please take one of them via -trivial.

I've applied my version to -trivial.

Thanks,

/mjt

  reply	other threads:[~2014-02-11 10:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-06 15:30 [Qemu-devel] [PATCH] net: Include iov.h in checksum.h Alexander Graf
2014-02-07  7:05 ` [Qemu-trivial] " Michael Tokarev
2014-02-07  7:05   ` Michael Tokarev
2014-02-07  7:54   ` [Qemu-trivial] " Alexander Graf
2014-02-07  7:54     ` Alexander Graf
2014-02-10 10:20     ` [Qemu-trivial] " Stefan Hajnoczi
2014-02-10 10:20       ` Stefan Hajnoczi
2014-02-11 10:30       ` Michael Tokarev [this message]
2014-02-11 10:30         ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52F9FBAE.50503@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=agraf@suse.de \
    --cc=aliguori@amazon.com \
    --cc=dmitry@daynix.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.