Re: [PATCHv2 4/4] pipe-loader: add pipe loader for freedreno/msm

[Emil Velikov <emil.l.velikov@gmail.com>]

On 11/02/14 12:09, Rob Clark wrote:
> On Mon, Feb 10, 2014 at 11:30 PM, Emil Velikov <emil.l.velikov@gmail.com> wrote:
>> On 10/02/14 18:34, Rob Clark wrote:
>>> From: Rob Clark <robclark@freedesktop.org>
>>>
>>> Signed-off-by: Rob Clark <robclark@freedesktop.org>
>>> ---
>>>  src/gallium/targets/pipe-loader/Makefile.am | 16 ++++++++++++++++
>>>  src/gallium/targets/pipe-loader/pipe_msm.c  | 21 +++++++++++++++++++++
>>>  2 files changed, 37 insertions(+)
>>>  create mode 100644 src/gallium/targets/pipe-loader/pipe_msm.c
>>>
>>> diff --git a/src/gallium/targets/pipe-loader/Makefile.am b/src/gallium/targets/pipe-loader/Makefile.am
>>> index 97733c1..8a0f254 100644
>>> --- a/src/gallium/targets/pipe-loader/Makefile.am
>>> +++ b/src/gallium/targets/pipe-loader/Makefile.am
>>> @@ -132,6 +132,22 @@ pipe_radeonsi_la_LDFLAGS += $(LLVM_LDFLAGS)
>>>  endif
>>>  endif
>>>
>>> +if HAVE_GALLIUM_FREEDRENO
>>> +pipe_LTLIBRARIES += pipe_msm.la
>>> +pipe_msm_la_SOURCES = pipe_msm.c
>>> +nodist_EXTRA_pipe_msm_la_SOURCES = dummy.cpp
>>> +pipe_msm_la_LIBADD = \
>>> +     $(PIPE_LIBS) \
>>> +     $(top_builddir)/src/gallium/winsys/freedreno/drm/libfreedrenodrm.la \
>>> +     $(top_builddir)/src/gallium/drivers/freedreno/libfreedreno.la \
>> Should have spotted this earlier, but it seems like you're forgot to
>> link against libdrm_freedreno ?
>>
>> + $(FREEDRENO_LIBS) \
> 
> hmm, good point.. I wonder why it works?
> 
Guessing that the linker favours us or there is a bug somewhere :)

>> -Emil