All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josef Bacik <jbacik@fb.com>
To: Wang Shilong <wangsl.fnst@cn.fujitsu.com>, <xfs@oss.sgi.com>
Cc: <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v2] xfstests: btrfs/004: fix to make test really work
Date: Tue, 11 Feb 2014 08:25:31 -0500	[thread overview]
Message-ID: <52FA24CB.3070103@fb.com> (raw)
In-Reply-To: <1392113204-29237-1-git-send-email-wangsl.fnst@cn.fujitsu.com>



On 02/11/2014 05:06 AM, Wang Shilong wrote:
> So i was wondering why test 004 could pass my previous wrong
> kernel patch while it defenitely should not.
>
> By some debugging, i found here perl script is wrong, we did not
> filter out anything and this unit test did not work acutally.so
> it came out we will never fail this test.
>
> Signed-off-by: Wang Shilong <wangsl.fnst@cn.fujitsu.com>
> ---

This works for me, you can add

Reviewed-by: Josef Bacik <jbacik@fb.com>

Thanks,

Josef

WARNING: multiple messages have this Message-ID (diff)
From: Josef Bacik <jbacik@fb.com>
To: Wang Shilong <wangsl.fnst@cn.fujitsu.com>, xfs@oss.sgi.com
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] xfstests: btrfs/004: fix to make test really work
Date: Tue, 11 Feb 2014 08:25:31 -0500	[thread overview]
Message-ID: <52FA24CB.3070103@fb.com> (raw)
In-Reply-To: <1392113204-29237-1-git-send-email-wangsl.fnst@cn.fujitsu.com>



On 02/11/2014 05:06 AM, Wang Shilong wrote:
> So i was wondering why test 004 could pass my previous wrong
> kernel patch while it defenitely should not.
>
> By some debugging, i found here perl script is wrong, we did not
> filter out anything and this unit test did not work acutally.so
> it came out we will never fail this test.
>
> Signed-off-by: Wang Shilong <wangsl.fnst@cn.fujitsu.com>
> ---

This works for me, you can add

Reviewed-by: Josef Bacik <jbacik@fb.com>

Thanks,

Josef

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2014-02-11 13:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-11 10:06 [PATCH v2] xfstests: btrfs/004: fix to make test really work Wang Shilong
2014-02-11 10:06 ` Wang Shilong
2014-02-11 13:25 ` Josef Bacik [this message]
2014-02-11 13:25   ` Josef Bacik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52FA24CB.3070103@fb.com \
    --to=jbacik@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wangsl.fnst@cn.fujitsu.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.