From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/5] drivers: of: add initialization code for reserved memory
Date: Tue, 11 Feb 2014 21:27:36 +0100 [thread overview]
Message-ID: <52FA87B8.8040203@gmail.com> (raw)
In-Reply-To: <20140211201933.GI841@joshc.qualcomm.com>
On 11.02.2014 21:19, Josh Cartwright wrote:
> On Tue, Feb 11, 2014 at 09:04:21PM +0100, Tomasz Figa wrote:
>>
>>
>> On 11.02.2014 21:02, Benjamin Herrenschmidt wrote:
>>> On Tue, 2014-02-11 at 19:01 +0000, Grant Likely wrote:
>>>
>>>>> except that the former IMHO better suits the definition of memory
>>>>> region, which I see as a single contiguous range of memory and can be
>>>>> simplified to have a single reg entry per region.
>>>>
>>>> My point is rather if multiple reg tuples are found in a reserved memory
>>>> node, the kernel must respect them and reserve the memory. I'm not
>>>> arguing about whether or not that makes for a good binding.
>>>
>>> agreed.
>>
>> My point is why, if the binding defines that just a single tuple should be
>> provided.
>
> FWIW, the usecase I had mentioned in reply to Grant in the patch 5/5
> thread [1] could make use of this. The shared memory region is split
> into a main chunk and several "auxiliary" chunk, but collectively these
> regions all share the same heap state.
>
> Josh
>
> 1: http://lkml.kernel.org/r/20140205192502.GO20228 at joshc.qualcomm.com
>
The use case seems fine, but I believe it could be properly represented
in device tree using multiple single-reg regions as well, unless the
consumer can request a block of memory that crosses boundary of two
sub-regions specified by reg entries of single region.
Best regards,
Tomasz
WARNING: multiple messages have this Message-ID (diff)
From: Tomasz Figa <tomasz.figa@gmail.com>
To: Josh Cartwright <joshc@codeaurora.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Grant Likely <grant.likely@linaro.org>,
Tomasz Figa <t.figa@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linaro-mm-sig@lists.linaro.org, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Arnd Bergmann <arnd@arndb.de>,
Michal Nazarewicz <mina86@mina86.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Laura Abbott <lauraa@codeaurora.org>,
Rob Herring <robh+dt@gmail.com>, Olof Johansson <olof@lixom.net>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ian.campbell@citrix.com>,
Kumar Gala <galak@codeaurora.org>,
Nishanth Peethambaran <nishanth.p@gmail.com>,
Marc <marc.ceeeee@gmail.com>
Subject: Re: [PATCH v2 1/5] drivers: of: add initialization code for reserved memory
Date: Tue, 11 Feb 2014 21:27:36 +0100 [thread overview]
Message-ID: <52FA87B8.8040203@gmail.com> (raw)
In-Reply-To: <20140211201933.GI841@joshc.qualcomm.com>
On 11.02.2014 21:19, Josh Cartwright wrote:
> On Tue, Feb 11, 2014 at 09:04:21PM +0100, Tomasz Figa wrote:
>>
>>
>> On 11.02.2014 21:02, Benjamin Herrenschmidt wrote:
>>> On Tue, 2014-02-11 at 19:01 +0000, Grant Likely wrote:
>>>
>>>>> except that the former IMHO better suits the definition of memory
>>>>> region, which I see as a single contiguous range of memory and can be
>>>>> simplified to have a single reg entry per region.
>>>>
>>>> My point is rather if multiple reg tuples are found in a reserved memory
>>>> node, the kernel must respect them and reserve the memory. I'm not
>>>> arguing about whether or not that makes for a good binding.
>>>
>>> agreed.
>>
>> My point is why, if the binding defines that just a single tuple should be
>> provided.
>
> FWIW, the usecase I had mentioned in reply to Grant in the patch 5/5
> thread [1] could make use of this. The shared memory region is split
> into a main chunk and several "auxiliary" chunk, but collectively these
> regions all share the same heap state.
>
> Josh
>
> 1: http://lkml.kernel.org/r/20140205192502.GO20228@joshc.qualcomm.com
>
The use case seems fine, but I believe it could be properly represented
in device tree using multiple single-reg regions as well, unless the
consumer can request a block of memory that crosses boundary of two
sub-regions specified by reg entries of single region.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-02-11 20:27 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 12:09 [PATCH v2 0/5] reserved-memory regions/CMA in devicetree, again Marek Szyprowski
2014-02-04 12:09 ` Marek Szyprowski
[not found] ` < 1391515773-6112-5-git-send-email-m.szyprowski@samsung.com>
[not found] ` < 1391515773-6112-2-git-send-email-m.szyprowski@samsung.com>
2014-02-04 12:09 ` [PATCH v2 1/5] drivers: of: add initialization code for reserved memory Marek Szyprowski
2014-02-04 12:09 ` Marek Szyprowski
[not found] ` < 20140205110538.99E47C40A89@trevor.secretlab.ca>
2014-02-05 11:05 ` Grant Likely
2014-02-05 11:05 ` Grant Likely
2014-02-05 11:05 ` Grant Likely
2014-02-11 11:45 ` Marek Szyprowski
2014-02-11 11:45 ` Marek Szyprowski
[not found] ` < 20140211121316.24032C40C4D@trevor.secretlab.ca>
2014-02-11 12:13 ` Grant Likely
2014-02-11 12:13 ` Grant Likely
2014-02-11 14:29 ` Tomasz Figa
2014-02-11 14:29 ` Tomasz Figa
2014-02-11 19:01 ` Grant Likely
2014-02-11 19:01 ` Grant Likely
2014-02-11 19:01 ` Grant Likely
2014-02-11 20:02 ` Benjamin Herrenschmidt
2014-02-11 20:02 ` Benjamin Herrenschmidt
2014-02-11 20:04 ` Tomasz Figa
2014-02-11 20:04 ` Tomasz Figa
2014-02-11 20:19 ` Josh Cartwright
2014-02-11 20:19 ` Josh Cartwright
2014-02-11 20:27 ` Tomasz Figa [this message]
2014-02-11 20:27 ` Tomasz Figa
2014-02-13 19:48 ` Josh Cartwright
2014-02-13 19:48 ` Josh Cartwright
2014-02-17 16:53 ` Grant Likely
2014-02-17 16:53 ` Grant Likely
2014-02-17 16:47 ` Grant Likely
2014-02-17 16:47 ` Grant Likely
2014-02-06 22:08 ` Laura Abbott
2014-02-06 22:08 ` Laura Abbott
2014-02-04 12:09 ` [PATCH v2 2/5] drivers: of: implement reserved-memory handling for dma Marek Szyprowski
2014-02-04 12:09 ` Marek Szyprowski
2014-02-04 12:09 ` Marek Szyprowski
2014-02-04 12:09 ` [PATCH v2 3/5] drivers: of: implement reserved-memory handling for cma Marek Szyprowski
2014-02-04 12:09 ` Marek Szyprowski
2014-02-05 11:09 ` Grant Likely
2014-02-05 11:09 ` Grant Likely
2014-02-05 11:09 ` Grant Likely
2014-02-04 12:09 ` [PATCH v2 4/5] ARM: init: add support for reserved memory defined by device tree Marek Szyprowski
2014-02-04 12:09 ` Marek Szyprowski
2014-02-05 10:15 ` Grant Likely
2014-02-05 10:15 ` Grant Likely
2014-02-05 10:15 ` Grant Likely
2014-02-06 13:26 ` Marek Szyprowski
2014-02-06 13:26 ` Marek Szyprowski
[not found] ` < 20140210215929.4473BC408F7@trevor.secretlab.ca>
2014-02-10 21:59 ` Grant Likely
2014-02-10 21:59 ` Grant Likely
2014-02-11 10:52 ` Marek Szyprowski
2014-02-11 10:52 ` Marek Szyprowski
2014-02-11 11:50 ` Grant Likely
2014-02-11 11:50 ` Grant Likely
2014-02-04 12:09 ` [PATCH v2 5/5] of: document bindings for reserved-memory nodes Marek Szyprowski
2014-02-04 12:09 ` Marek Szyprowski
2014-02-05 10:07 ` Grant Likely
2014-02-05 10:07 ` Grant Likely
2014-02-05 10:07 ` Grant Likely
2014-02-05 19:25 ` Josh Cartwright
2014-02-05 19:25 ` Josh Cartwright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FA87B8.8040203@gmail.com \
--to=tomasz.figa@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.