From: Thomas Hellstrom <thellstrom@vmware.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: David Airlie <airlied@linux.ie>,
Jakob Bornecrantz <jakob@vmware.com>,
Zack Rusin <zackr@vmware.com>, Brian Paul <brianp@vmware.com>,
dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] drm/vmwgfx: add error checking for kmalloc()
Date: Wed, 12 Feb 2014 11:26:22 +0000 [thread overview]
Message-ID: <52FB5A5E.2040309@vmware.com> (raw)
In-Reply-To: <20140211160416.GB9406@elgon.mountain>
On 02/11/2014 05:04 PM, Dan Carpenter wrote:
> Return -ENOMEM if kmalloc() fails.
>
> Fixes: d5bde956630b ('drm/vmwgfx: Emulate legacy shaders on guest-backed devices v2')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_shader.c b/drivers/gpu/drm/vmwgfx/vmwgfx_shader.c
> index 217d941b8176..23a32fd59a57 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_shader.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_shader.c
> @@ -779,6 +779,8 @@ vmw_compat_shader_man_create(struct vmw_private *dev_priv)
> int ret;
>
> man = kzalloc(sizeof(*man), GFP_KERNEL);
> + if (!man)
> + return ERR_PTR(-ENOMEM);
>
> man->dev_priv = dev_priv;
> INIT_LIST_HEAD(&man->list);
Thanks, Dan.
A patch fixing the same problem has already been queued for the next
vmwgfx-fixes!
/Thomas
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Hellstrom <thellstrom@vmware.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: David Airlie <airlied@linux.ie>,
Jakob Bornecrantz <jakob@vmware.com>,
Zack Rusin <zackr@vmware.com>, Brian Paul <brianp@vmware.com>,
dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] drm/vmwgfx: add error checking for kmalloc()
Date: Wed, 12 Feb 2014 12:26:22 +0100 [thread overview]
Message-ID: <52FB5A5E.2040309@vmware.com> (raw)
In-Reply-To: <20140211160416.GB9406@elgon.mountain>
On 02/11/2014 05:04 PM, Dan Carpenter wrote:
> Return -ENOMEM if kmalloc() fails.
>
> Fixes: d5bde956630b ('drm/vmwgfx: Emulate legacy shaders on guest-backed devices v2')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_shader.c b/drivers/gpu/drm/vmwgfx/vmwgfx_shader.c
> index 217d941b8176..23a32fd59a57 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_shader.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_shader.c
> @@ -779,6 +779,8 @@ vmw_compat_shader_man_create(struct vmw_private *dev_priv)
> int ret;
>
> man = kzalloc(sizeof(*man), GFP_KERNEL);
> + if (!man)
> + return ERR_PTR(-ENOMEM);
>
> man->dev_priv = dev_priv;
> INIT_LIST_HEAD(&man->list);
Thanks, Dan.
A patch fixing the same problem has already been queued for the next
vmwgfx-fixes!
/Thomas
next prev parent reply other threads:[~2014-02-12 11:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 16:04 [patch] drm/vmwgfx: add error checking for kmalloc() Dan Carpenter
2014-02-11 16:04 ` Dan Carpenter
2014-02-12 11:26 ` Thomas Hellstrom [this message]
2014-02-12 11:26 ` Thomas Hellstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FB5A5E.2040309@vmware.com \
--to=thellstrom@vmware.com \
--cc=airlied@linux.ie \
--cc=brianp@vmware.com \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jakob@vmware.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=zackr@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.