From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] ARM: shmobile: set proper DMA masks for Ether devices
Date: Wed, 12 Feb 2014 11:32:32 +0000 [thread overview]
Message-ID: <52FB5BD0.10707@cogentembedded.com> (raw)
In-Reply-To: <201402120255.25037.sergei.shtylyov@cogentembedded.com>
Hello.
On 12-02-2014 5:35, Simon Horman wrote:
>> Ether MAC is a DMA-capable device and so should have 'dev.dma_mask' and
>> 'dev.coherent_dma_mask' fields set properly, to reflect 32-bit DMA addressing
>> ability. Currently, the code works without DMA masks but in the future, when
>> support for NETIF_F_HIGHDMA & NETIF_F_SG would be added to the 'sh_eth' driver,
>> the DMA masks should start to matter...
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Hi Sergei,
> please split this series up so there is a separate patch for each board.
Hm, I, contrariwise, gathered all board patches in the single patch. Could
you elaborate on why you deem it necessary to split it?
> Thanks
WBR, Sergei
next prev parent reply other threads:[~2014-02-12 11:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 22:55 [PATCH] ARM: shmobile: set proper DMA masks for Ether devices Sergei Shtylyov
2014-02-11 23:55 ` Sergei Shtylyov
2014-02-12 1:35 ` Simon Horman
2014-02-12 1:35 ` Simon Horman
2014-02-12 11:32 ` Sergei Shtylyov [this message]
2014-02-12 23:45 ` Simon Horman
2014-02-12 23:45 ` Simon Horman
2014-02-12 11:49 ` Ben Dooks
2014-02-12 11:49 ` Ben Dooks
2014-02-12 13:25 ` Sergei Shtylyov
2014-02-12 13:25 ` Sergei Shtylyov
2014-02-12 14:28 ` Ben Dooks
2014-02-12 14:28 ` Ben Dooks
2014-02-12 14:58 ` Sergei Shtylyov
2014-02-12 14:58 ` Sergei Shtylyov
2014-02-12 15:11 ` Ben Dooks
2014-02-12 15:11 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FB5BD0.10707@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.