All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: shmobile: set proper DMA masks for Ether devices
Date: Wed, 12 Feb 2014 14:58:52 +0000	[thread overview]
Message-ID: <52FB8C2C.1050909@cogentembedded.com> (raw)
In-Reply-To: <52FB8526.9000601@codethink.co.uk>

Hello.

On 12-02-2014 18:28, Ben Dooks wrote:

>>>> Ether MAC is a DMA-capable device and so should have 'dev.dma_mask' and
>>>> 'dev.coherent_dma_mask' fields set properly, to reflect 32-bit DMA
>>>> addressing
>>>> ability.  Currently, the code works without DMA masks but in the
>>>> future, when
>>>> support for NETIF_F_HIGHDMA & NETIF_F_SG would be added to the
>>>> 'sh_eth' driver,
>>>> the DMA masks should start to matter...

>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

>>> Hi, do you have a git branch available with all the changes for getting
>>> ethernet working on rcar please?

>>     Depends on whether you want it working via DT or mere platform
>> devices. If the second, it's 3.14-rc1. If DT, I don't have a branch,
>> only several patches to apply atop of the current 'renesas.git' repo's
>> 'devel' branch that I've posted last week (note that only R8A779x is
>> currently supported by these patches and NFS boot timeout is still an
>> issue with them).

> ok, I have a slightly earlier version which seems to work with nfs
> boot for me.

    There's no "slightly earlier version" (unless you mean DT support for 
BOCK-W posted months ago). Issue with NFS is not fatal, it boots fine, just 
somewhat slow.

WBR, Sergei


WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: shmobile: set proper DMA masks for Ether devices
Date: Wed, 12 Feb 2014 18:58:52 +0400	[thread overview]
Message-ID: <52FB8C2C.1050909@cogentembedded.com> (raw)
In-Reply-To: <52FB8526.9000601@codethink.co.uk>

Hello.

On 12-02-2014 18:28, Ben Dooks wrote:

>>>> Ether MAC is a DMA-capable device and so should have 'dev.dma_mask' and
>>>> 'dev.coherent_dma_mask' fields set properly, to reflect 32-bit DMA
>>>> addressing
>>>> ability.  Currently, the code works without DMA masks but in the
>>>> future, when
>>>> support for NETIF_F_HIGHDMA & NETIF_F_SG would be added to the
>>>> 'sh_eth' driver,
>>>> the DMA masks should start to matter...

>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

>>> Hi, do you have a git branch available with all the changes for getting
>>> ethernet working on rcar please?

>>     Depends on whether you want it working via DT or mere platform
>> devices. If the second, it's 3.14-rc1. If DT, I don't have a branch,
>> only several patches to apply atop of the current 'renesas.git' repo's
>> 'devel' branch that I've posted last week (note that only R8A779x is
>> currently supported by these patches and NFS boot timeout is still an
>> issue with them).

> ok, I have a slightly earlier version which seems to work with nfs
> boot for me.

    There's no "slightly earlier version" (unless you mean DT support for 
BOCK-W posted months ago). Issue with NFS is not fatal, it boots fine, just 
somewhat slow.

WBR, Sergei

  reply	other threads:[~2014-02-12 14:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-11 22:55 [PATCH] ARM: shmobile: set proper DMA masks for Ether devices Sergei Shtylyov
2014-02-11 23:55 ` Sergei Shtylyov
2014-02-12  1:35 ` Simon Horman
2014-02-12  1:35   ` Simon Horman
2014-02-12 11:32 ` Sergei Shtylyov
2014-02-12 23:45   ` Simon Horman
2014-02-12 23:45     ` Simon Horman
2014-02-12 11:49 ` Ben Dooks
2014-02-12 11:49   ` Ben Dooks
2014-02-12 13:25   ` Sergei Shtylyov
2014-02-12 13:25     ` Sergei Shtylyov
2014-02-12 14:28     ` Ben Dooks
2014-02-12 14:28       ` Ben Dooks
2014-02-12 14:58       ` Sergei Shtylyov [this message]
2014-02-12 14:58         ` Sergei Shtylyov
2014-02-12 15:11         ` Ben Dooks
2014-02-12 15:11           ` Ben Dooks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52FB8C2C.1050909@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.