Re: f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

[Andrey Tsyvarev <tsyvarev@ispras.ru>]

Hi,

> BTW, have you tested the case that added remove_dirty_dir_inode() into the fail path
> of init_inode_metadata?
> diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c
> index e095a4f..d5a2c9e 100644
> --- a/fs/f2fs/dir.c
> +++ b/fs/f2fs/dir.c
> @@ -375,6 +375,7 @@ put_error:
>          /* once the failed inode becomes a bad inode, i_mode is S_IFREG */
>          truncate_inode_pages(&inode->i_data, 0);
>          truncate_blocks(inode, 0);
> +       remove_dirty_dir_inode(inode);
>   error:
>          remove_inode_page(inode);
>          return ERR_PTR(err);
Yes, i have tested that case. Fail in init_inode_metadata has been 
processed correctly. Thanks.

-- 
Best regards,

Andrey Tsyvarev

Linux Verification Center, ISPRAS

web:http://linuxtesting.org


------------------------------------------------------------------------------
Android apps run on BlackBerry 10
Introducing the new BlackBerry 10.2.1 Runtime for Android apps.
Now with support for Jelly Bean, Bluetooth, Mapview and more.
Get your Android app in front of a whole new audience.  Start now.
http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk