From: Rik van Riel <riel@redhat.com>
To: Weijie Yang <weijie.yang@samsung.com>, 'Mel Gorman' <mgorman@suse.de>
Cc: 'Andrew Morton' <akpm@linux-foundation.org>,
'Minchan Kim' <minchan@kernel.org>,
weijie.yang.kh@gmail.com, 'Linux-MM' <linux-mm@kvack.org>,
'linux-kernel' <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] mm/vmscan: not check compaction_ready on promoted zones
Date: Thu, 13 Feb 2014 11:11:08 -0500 [thread overview]
Message-ID: <52FCEE9C.2040001@redhat.com> (raw)
In-Reply-To: <000101cf2865$2a8411a0$7f8c34e0$%yang@samsung.com>
On 02/12/2014 09:41 PM, Weijie Yang wrote:
> We abort direct reclaim if find the zone is ready for compaction.
>
> Sometimes the zone is just a promoted highmem zone to force scan
> pinning highmem, which is not the intended zone the caller want to
> alloc page from. In this situation, setting aborted_reclaim to
> indicate the caller turn back to retry allocation is waste of time
> and could cause a loop in __alloc_pages_slowpath().
>
> This patch do not check compaction_ready() on promoted zones to avoid
> the above situation, only set aborted_reclaim if the caller intended
> zone is ready to compaction.
>
> Signed-off-by: Weijie Yang <weijie.yang@samsung.com>
Acked-by: Rik van Riel <riel@redhat.com>
--
All rights reversed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Weijie Yang <weijie.yang@samsung.com>, "'Mel Gorman'" <mgorman@suse.de>
Cc: "'Andrew Morton'" <akpm@linux-foundation.org>,
"'Minchan Kim'" <minchan@kernel.org>,
weijie.yang.kh@gmail.com, "'Linux-MM'" <linux-mm@kvack.org>,
"'linux-kernel'" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] mm/vmscan: not check compaction_ready on promoted zones
Date: Thu, 13 Feb 2014 11:11:08 -0500 [thread overview]
Message-ID: <52FCEE9C.2040001@redhat.com> (raw)
In-Reply-To: <000101cf2865$2a8411a0$7f8c34e0$%yang@samsung.com>
On 02/12/2014 09:41 PM, Weijie Yang wrote:
> We abort direct reclaim if find the zone is ready for compaction.
>
> Sometimes the zone is just a promoted highmem zone to force scan
> pinning highmem, which is not the intended zone the caller want to
> alloc page from. In this situation, setting aborted_reclaim to
> indicate the caller turn back to retry allocation is waste of time
> and could cause a loop in __alloc_pages_slowpath().
>
> This patch do not check compaction_ready() on promoted zones to avoid
> the above situation, only set aborted_reclaim if the caller intended
> zone is ready to compaction.
>
> Signed-off-by: Weijie Yang <weijie.yang@samsung.com>
Acked-by: Rik van Riel <riel@redhat.com>
--
All rights reversed
next prev parent reply other threads:[~2014-02-13 16:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 2:41 [PATCH 2/2] mm/vmscan: not check compaction_ready on promoted zones Weijie Yang
2014-02-13 2:41 ` Weijie Yang
2014-02-13 16:11 ` Rik van Riel [this message]
2014-02-13 16:11 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FCEE9C.2040001@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=weijie.yang.kh@gmail.com \
--cc=weijie.yang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.