From: Stephen Warren <swarren@wwwdotorg.org>
To: Thierry Reding <thierry.reding@gmail.com>,
Marc Dietrich <marvin24@gmx.de>
Cc: Stefan Agner <stefan@agner.ch>,
josephl@nvidia.com, dev@lynxeye.de, linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: tegra: don't timeout if CPU is powergated
Date: Thu, 13 Feb 2014 09:36:06 -0700 [thread overview]
Message-ID: <52FCF476.4010908@wwwdotorg.org> (raw)
In-Reply-To: <20140213084907.GA11795@ulmo.nvidia.com>
On 02/13/2014 01:49 AM, Thierry Reding wrote:
> On Thu, Feb 13, 2014 at 09:28:52AM +0100, Marc Dietrich wrote:
>> Am Mittwoch, 12. Februar 2014, 12:20:29 schrieb Stephen Warren:
>>> On 02/10/2014 05:44 PM, Stefan Agner wrote:
>>>> When booting secondary CPU(s) which are not yet powergated, a wrong
>>>> check lead to a timeout after 100 jiffies. With this patch, we only
>>>> delay powergating if CPUs are still not powered yet.
>>>
>>> I've applied this to Tegra's for-3.15/soc branch.
>>
>> also for 3.14 and maybe lower versioned kernels? Since this seems to fix a bug
>> where some core doesn't come up.
>
> Yeah, this bug has been there for pretty much forever it seems. Commit
> 86e51a2ee471 "ARM: tegra: support for secondary cores on Tegra30" added
> tegra30_boot_secondary() (named tegra30_power_up_cpu() back then, which
> was renamed to tegra30_boot_secondary() in commit 0d1f79b033bb "ARM:
> tegra: refactor tegra{20,30}_boot_secondary". The latter was introduced
> in v3.10, so I guess backporting it to stable releases all the way back
> to v3.10 would be good.
>
> Backporting to earlier versions (86e51a2ee471 went into v3.4) will be a
> lot more difficult since some of the APIs were renamed since then.
I'm actually uninclined to backport this; I've never once seen an issue
because of this problem, and nobody has reported it in older kernels.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: tegra: don't timeout if CPU is powergated
Date: Thu, 13 Feb 2014 09:36:06 -0700 [thread overview]
Message-ID: <52FCF476.4010908@wwwdotorg.org> (raw)
In-Reply-To: <20140213084907.GA11795@ulmo.nvidia.com>
On 02/13/2014 01:49 AM, Thierry Reding wrote:
> On Thu, Feb 13, 2014 at 09:28:52AM +0100, Marc Dietrich wrote:
>> Am Mittwoch, 12. Februar 2014, 12:20:29 schrieb Stephen Warren:
>>> On 02/10/2014 05:44 PM, Stefan Agner wrote:
>>>> When booting secondary CPU(s) which are not yet powergated, a wrong
>>>> check lead to a timeout after 100 jiffies. With this patch, we only
>>>> delay powergating if CPUs are still not powered yet.
>>>
>>> I've applied this to Tegra's for-3.15/soc branch.
>>
>> also for 3.14 and maybe lower versioned kernels? Since this seems to fix a bug
>> where some core doesn't come up.
>
> Yeah, this bug has been there for pretty much forever it seems. Commit
> 86e51a2ee471 "ARM: tegra: support for secondary cores on Tegra30" added
> tegra30_boot_secondary() (named tegra30_power_up_cpu() back then, which
> was renamed to tegra30_boot_secondary() in commit 0d1f79b033bb "ARM:
> tegra: refactor tegra{20,30}_boot_secondary". The latter was introduced
> in v3.10, so I guess backporting it to stable releases all the way back
> to v3.10 would be good.
>
> Backporting to earlier versions (86e51a2ee471 went into v3.4) will be a
> lot more difficult since some of the APIs were renamed since then.
I'm actually uninclined to backport this; I've never once seen an issue
because of this problem, and nobody has reported it in older kernels.
next prev parent reply other threads:[~2014-02-13 16:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 0:44 [PATCH] ARM: tegra: don't timeout if CPU is powergated Stefan Agner
2014-02-11 0:44 ` Stefan Agner
[not found] ` <1d5ea6b7df4573d866779857922ac650fe59af60.1392078805.git.stefan-XLVq0VzYD2Y@public.gmane.org>
2014-02-11 21:18 ` Thierry Reding
2014-02-11 21:18 ` Thierry Reding
2014-02-11 21:18 ` Thierry Reding
2014-02-12 19:20 ` Stephen Warren
2014-02-12 19:20 ` Stephen Warren
[not found] ` <52FBC97D.8040809-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-02-13 8:28 ` Marc Dietrich
2014-02-13 8:28 ` Marc Dietrich
2014-02-13 8:28 ` Marc Dietrich
2014-02-13 8:49 ` Thierry Reding
2014-02-13 8:49 ` Thierry Reding
2014-02-13 8:49 ` Thierry Reding
2014-02-13 16:36 ` Stephen Warren [this message]
2014-02-13 16:36 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FCF476.4010908@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=dev@lynxeye.de \
--cc=josephl@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marvin24@gmx.de \
--cc=stefan@agner.ch \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.