From: Tero Kristo <t-kristo@ti.com>
To: Tony Lindgren <tony@atomide.com>, Nishanth Menon <nm@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Paul Walmsley <paul@pwsan.com>
Subject: Re: [PATCH] ARM: OMAP3+: DPLL: stop reparenting to same parent if already done
Date: Fri, 14 Feb 2014 15:13:44 +0200 [thread overview]
Message-ID: <52FE1688.7080105@ti.com> (raw)
In-Reply-To: <20140213231317.GN28216@atomide.com>
On 02/14/2014 01:13 AM, Tony Lindgren wrote:
> * Nishanth Menon <nm@ti.com> [140205 01:06]:
>> omap3_noncore_dpll_set_rate forces a reparent to the same clk_ref
>> for every call that takes place. This is an can be done only if a change
>> is detected.
>>
>> Signed-off-by: Nishanth Menon <nm@ti.com>
>
> Would like to see acks on this too before applying.
Looks good to me, ack.
-Tero
>
> Tony
>
>> ---
>> arch/arm/mach-omap2/dpll3xxx.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-omap2/dpll3xxx.c b/arch/arm/mach-omap2/dpll3xxx.c
>> index 3185ced..d9bcbf7 100644
>> --- a/arch/arm/mach-omap2/dpll3xxx.c
>> +++ b/arch/arm/mach-omap2/dpll3xxx.c
>> @@ -525,7 +525,7 @@ int omap3_noncore_dpll_set_rate(struct clk_hw *hw, unsigned long rate,
>> * stuff is inherited for free
>> */
>>
>> - if (!ret)
>> + if (!ret && clk_get_parent(hw->clk) != new_parent)
>> __clk_reparent(hw->clk, new_parent);
>>
>> return 0;
>> --
>> 1.7.9.5
>>
WARNING: multiple messages have this Message-ID (diff)
From: t-kristo@ti.com (Tero Kristo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP3+: DPLL: stop reparenting to same parent if already done
Date: Fri, 14 Feb 2014 15:13:44 +0200 [thread overview]
Message-ID: <52FE1688.7080105@ti.com> (raw)
In-Reply-To: <20140213231317.GN28216@atomide.com>
On 02/14/2014 01:13 AM, Tony Lindgren wrote:
> * Nishanth Menon <nm@ti.com> [140205 01:06]:
>> omap3_noncore_dpll_set_rate forces a reparent to the same clk_ref
>> for every call that takes place. This is an can be done only if a change
>> is detected.
>>
>> Signed-off-by: Nishanth Menon <nm@ti.com>
>
> Would like to see acks on this too before applying.
Looks good to me, ack.
-Tero
>
> Tony
>
>> ---
>> arch/arm/mach-omap2/dpll3xxx.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-omap2/dpll3xxx.c b/arch/arm/mach-omap2/dpll3xxx.c
>> index 3185ced..d9bcbf7 100644
>> --- a/arch/arm/mach-omap2/dpll3xxx.c
>> +++ b/arch/arm/mach-omap2/dpll3xxx.c
>> @@ -525,7 +525,7 @@ int omap3_noncore_dpll_set_rate(struct clk_hw *hw, unsigned long rate,
>> * stuff is inherited for free
>> */
>>
>> - if (!ret)
>> + if (!ret && clk_get_parent(hw->clk) != new_parent)
>> __clk_reparent(hw->clk, new_parent);
>>
>> return 0;
>> --
>> 1.7.9.5
>>
WARNING: multiple messages have this Message-ID (diff)
From: Tero Kristo <t-kristo@ti.com>
To: Tony Lindgren <tony@atomide.com>, Nishanth Menon <nm@ti.com>
Cc: <linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, Paul Walmsley <paul@pwsan.com>
Subject: Re: [PATCH] ARM: OMAP3+: DPLL: stop reparenting to same parent if already done
Date: Fri, 14 Feb 2014 15:13:44 +0200 [thread overview]
Message-ID: <52FE1688.7080105@ti.com> (raw)
In-Reply-To: <20140213231317.GN28216@atomide.com>
On 02/14/2014 01:13 AM, Tony Lindgren wrote:
> * Nishanth Menon <nm@ti.com> [140205 01:06]:
>> omap3_noncore_dpll_set_rate forces a reparent to the same clk_ref
>> for every call that takes place. This is an can be done only if a change
>> is detected.
>>
>> Signed-off-by: Nishanth Menon <nm@ti.com>
>
> Would like to see acks on this too before applying.
Looks good to me, ack.
-Tero
>
> Tony
>
>> ---
>> arch/arm/mach-omap2/dpll3xxx.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-omap2/dpll3xxx.c b/arch/arm/mach-omap2/dpll3xxx.c
>> index 3185ced..d9bcbf7 100644
>> --- a/arch/arm/mach-omap2/dpll3xxx.c
>> +++ b/arch/arm/mach-omap2/dpll3xxx.c
>> @@ -525,7 +525,7 @@ int omap3_noncore_dpll_set_rate(struct clk_hw *hw, unsigned long rate,
>> * stuff is inherited for free
>> */
>>
>> - if (!ret)
>> + if (!ret && clk_get_parent(hw->clk) != new_parent)
>> __clk_reparent(hw->clk, new_parent);
>>
>> return 0;
>> --
>> 1.7.9.5
>>
next prev parent reply other threads:[~2014-02-14 13:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 9:04 [PATCH] ARM: OMAP3+: DPLL: stop reparenting to same parent if already done Nishanth Menon
2014-02-05 9:04 ` Nishanth Menon
2014-02-05 9:04 ` Nishanth Menon
2014-02-13 23:13 ` Tony Lindgren
2014-02-13 23:13 ` Tony Lindgren
2014-02-14 13:13 ` Tero Kristo [this message]
2014-02-14 13:13 ` Tero Kristo
2014-02-14 13:13 ` Tero Kristo
2014-02-20 3:04 ` Paul Walmsley
2014-02-20 3:04 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FE1688.7080105@ti.com \
--to=t-kristo@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=paul@pwsan.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.