From: Ben Greear <greearb@candelatech.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 1/2] ath10k: add vdev-id, return code to error codes
Date: Fri, 14 Feb 2014 07:33:58 -0800 [thread overview]
Message-ID: <52FE3766.1080509@candelatech.com> (raw)
In-Reply-To: <87bnya6xey.fsf@kamboji.qca.qualcomm.com>
On 02/13/2014 10:06 PM, Kalle Valo wrote:
> @@ -1542,20 +1542,20 @@ static int ath10k_station_assoc(struct ath10k *ar, struct ath10k_vif *arvif,
>
> ret = ath10k_setup_peer_smps(ar, arvif, sta->addr, &sta->ht_cap);
> if (ret) {
> - ath10k_warn("failed to setup peer SMPS: %d\n", ret);
> + ath10k_warn("failed to setup peer SMPS for vdev: %d\n", ret);
> return ret;
> }
Looks like that could use the vdev id in it...I must have missed it on my first attempt.
> @@ -3252,7 +3252,7 @@ static int ath10k_sta_state(struct ieee80211_hw *hw,
> arvif->vdev_id, sta->addr);
> ret = ath10k_peer_delete(ar, arvif->vdev_id, sta->addr);
> if (ret)
> - ath10k_warn("Failed to delete peer: %pM for VDEV: %d ret %i\n",
> + ath10k_warn("Failed to delete peer %pM for vdev %d: %i\n",
> sta->addr, arvif->vdev_id, ret);
While you are harmonizing the messages...maybe change all instances of "failed to "Failed ?
I wasn't sure what was preferred so I left that alone when doing my patch.
The rest of the changes look fine to me.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Ben Greear <greearb@candelatech.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] ath10k: add vdev-id, return code to error codes
Date: Fri, 14 Feb 2014 07:33:58 -0800 [thread overview]
Message-ID: <52FE3766.1080509@candelatech.com> (raw)
In-Reply-To: <87bnya6xey.fsf@kamboji.qca.qualcomm.com>
On 02/13/2014 10:06 PM, Kalle Valo wrote:
> @@ -1542,20 +1542,20 @@ static int ath10k_station_assoc(struct ath10k *ar, struct ath10k_vif *arvif,
>
> ret = ath10k_setup_peer_smps(ar, arvif, sta->addr, &sta->ht_cap);
> if (ret) {
> - ath10k_warn("failed to setup peer SMPS: %d\n", ret);
> + ath10k_warn("failed to setup peer SMPS for vdev: %d\n", ret);
> return ret;
> }
Looks like that could use the vdev id in it...I must have missed it on my first attempt.
> @@ -3252,7 +3252,7 @@ static int ath10k_sta_state(struct ieee80211_hw *hw,
> arvif->vdev_id, sta->addr);
> ret = ath10k_peer_delete(ar, arvif->vdev_id, sta->addr);
> if (ret)
> - ath10k_warn("Failed to delete peer: %pM for VDEV: %d ret %i\n",
> + ath10k_warn("Failed to delete peer %pM for vdev %d: %i\n",
> sta->addr, arvif->vdev_id, ret);
While you are harmonizing the messages...maybe change all instances of "failed to "Failed ?
I wasn't sure what was preferred so I left that alone when doing my patch.
The rest of the changes look fine to me.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2014-02-14 15:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 19:09 [PATCH 1/2] ath10k: add vdev-id, return code to error codes greearb
2014-02-13 19:09 ` greearb
2014-02-13 19:09 ` [PATCH 2/2] ath10k: do not ratelimit ath10k_warn messages greearb
2014-02-13 19:09 ` greearb
2014-02-13 19:56 ` Kalle Valo
2014-02-13 19:56 ` Kalle Valo
2014-02-13 20:32 ` Ben Greear
2014-02-13 20:32 ` Ben Greear
2014-02-14 6:06 ` [PATCH 1/2] ath10k: add vdev-id, return code to error codes Kalle Valo
2014-02-14 6:06 ` Kalle Valo
2014-02-14 15:33 ` Ben Greear [this message]
2014-02-14 15:33 ` Ben Greear
2014-03-03 15:32 ` Kalle Valo
2014-03-03 15:32 ` Kalle Valo
2014-02-26 18:28 ` Ben Greear
2014-02-26 18:28 ` Ben Greear
2014-02-27 8:43 ` Kalle Valo
2014-02-27 8:43 ` Kalle Valo
2014-03-03 15:39 ` Kalle Valo
2014-03-03 15:39 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FE3766.1080509@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.