From: Nikolay Aleksandrov <nikolay@redhat.com>
To: netfilter-devel@vger.kernel.org
Cc: pablo@netfilter.org, kaber@trash.net
Subject: Re: [RFC PATCH] netfilter: nf_tables: add new write expression
Date: Sat, 15 Feb 2014 14:19:09 +0100 [thread overview]
Message-ID: <52FF694D.1070700@redhat.com> (raw)
In-Reply-To: <1392470242-4515-1-git-send-email-nikolay@redhat.com>
On 02/15/2014 02:17 PM, Nikolay Aleksandrov wrote:
> The new "write" expression can be used to manipulate packet data.
> The parameters that it has are source register (source for the bytes
> which are to be written), offset in the packet and length to write.
> It uses a select_ops method to choose between fast ops in the cases
> length is 1,2 or 4 bytes and slow ops (i.e. using memcpy) in other
> cases.
>
> Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
> ---
> I needed a way (other than passing the packets to user-space) to alter
> the ToS field via nftables, so I decided to make it a bit more general. I
> use it with the immediate expression to load the new ToS and then write it.
> If you find this useful I can post the libnftnl patch as well.
> Right now as you can see it continues even if the "write" wasn't successful
> which should be probably changed to NFT_BREAK for that case.
> This patch applies to Dave's net-next tree.
>
And I'll fix the direct skb->data references and some other small issues,
thus the RFC :-)
next prev parent reply other threads:[~2014-02-15 13:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-15 13:17 [RFC PATCH] netfilter: nf_tables: add new write expression Nikolay Aleksandrov
2014-02-15 13:19 ` Nikolay Aleksandrov [this message]
2014-02-15 13:30 ` Patrick McHardy
2014-02-15 13:35 ` Nikolay Aleksandrov
2014-02-16 10:09 ` Pablo Neira Ayuso
2014-02-16 10:36 ` Patrick McHardy
2014-02-16 10:49 ` Nikolay Aleksandrov
2014-02-16 11:00 ` Patrick McHardy
2014-02-16 11:05 ` Nikolay Aleksandrov
2014-02-15 13:36 ` Florian Westphal
2014-02-15 13:38 ` Nikolay Aleksandrov
2014-02-15 13:43 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FF694D.1070700@redhat.com \
--to=nikolay@redhat.com \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.