From: Nikolay Aleksandrov <nikolay@redhat.com>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org, pablo@netfilter.org, kaber@trash.net
Subject: Re: [RFC PATCH] netfilter: nf_tables: add new write expression
Date: Sat, 15 Feb 2014 14:38:21 +0100 [thread overview]
Message-ID: <52FF6DCD.6090509@redhat.com> (raw)
In-Reply-To: <20140215133613.GB28751@breakpoint.cc>
On 02/15/2014 02:36 PM, Florian Westphal wrote:
> Nikolay Aleksandrov <nikolay@redhat.com> wrote:
>> The new "write" expression can be used to manipulate packet data.
>
> Thanks. This is very useful feature (needed also for TCPMSS mangling
> for instance).
>
> General question: How are/should packet checksums be handled after packet
> content was altered?
>
hehe very good question, right now I do it with a hacked version of this
patch, but I think we can add some more generic checksum op where you can
choose which checksum to recompute. I've also thought about making the
destination (where to write the checksum) variable for some corner cases,
but this is a stretch.
Cheers,
Nik
next prev parent reply other threads:[~2014-02-15 13:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-15 13:17 [RFC PATCH] netfilter: nf_tables: add new write expression Nikolay Aleksandrov
2014-02-15 13:19 ` Nikolay Aleksandrov
2014-02-15 13:30 ` Patrick McHardy
2014-02-15 13:35 ` Nikolay Aleksandrov
2014-02-16 10:09 ` Pablo Neira Ayuso
2014-02-16 10:36 ` Patrick McHardy
2014-02-16 10:49 ` Nikolay Aleksandrov
2014-02-16 11:00 ` Patrick McHardy
2014-02-16 11:05 ` Nikolay Aleksandrov
2014-02-15 13:36 ` Florian Westphal
2014-02-15 13:38 ` Nikolay Aleksandrov [this message]
2014-02-15 13:43 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FF6DCD.6090509@redhat.com \
--to=nikolay@redhat.com \
--cc=fw@strlen.de \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.