All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <rolandd@cisco.com>
To: Christoph Hellwig <hch@lst.de>
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
	linux-kernel@vger.kernel.org, openib-general@openib.org,
	linux-scsi@vger.kernel.org
Subject: Re: Re: [PATCH/RFC] IB: Add SCSI RDMA Protocol (SRP) initiator
Date: Mon, 31 Oct 2005 21:03:35 -0800	[thread overview]
Message-ID: <52acgpgdso.fsf@cisco.com> (raw)
In-Reply-To: <20051101045800.GA25519@lst.de> (Christoph Hellwig's message of "Tue, 1 Nov 2005 05:58:00 +0100")

    Christoph> No. Bitfields for accessing hardware/wire
    Christoph> datastructures are wrong and will always break in some
    Christoph> circumstances.  Your header is much better.

OK, that's my feeling as well.

Would it make sense for me to split the pure SRP spec structures and
so on into a separate file and put it in include/scsi/srp.h?  Then we
can move ibmvscsi towards using that file.

 - R.

WARNING: multiple messages have this Message-ID (diff)
From: Roland Dreier <rolandd@cisco.com>
To: Christoph Hellwig <hch@lst.de>
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
	openib-general@openib.org, linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org
Subject: Re: [openib-general] Re: [PATCH/RFC] IB: Add SCSI RDMA Protocol (SRP) initiator
Date: Mon, 31 Oct 2005 21:03:35 -0800	[thread overview]
Message-ID: <52acgpgdso.fsf@cisco.com> (raw)
In-Reply-To: <20051101045800.GA25519@lst.de> (Christoph Hellwig's message of "Tue, 1 Nov 2005 05:58:00 +0100")

    Christoph> No. Bitfields for accessing hardware/wire
    Christoph> datastructures are wrong and will always break in some
    Christoph> circumstances.  Your header is much better.

OK, that's my feeling as well.

Would it make sense for me to split the pure SRP spec structures and
so on into a separate file and put it in include/scsi/srp.h?  Then we
can move ibmvscsi towards using that file.

 - R.

  reply	other threads:[~2005-11-01  5:03 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-31 17:23 [PATCH/RFC] IB: Add SCSI RDMA Protocol (SRP) initiator Roland Dreier
2005-11-01  0:28 ` [openib-general] " Grant Grundler
2005-11-01  4:51   ` Roland Dreier
2005-11-02 21:34   ` [PATCH/RFC v2] " Roland Dreier
2005-11-02 22:03     ` Michael S. Tsirkin
2005-11-02 22:04       ` Roland Dreier
2005-11-02 22:04         ` Roland Dreier
2005-11-02 22:08       ` Roland Dreier
2005-11-02 22:08         ` Roland Dreier
2005-11-01  2:04 ` [PATCH/RFC] " FUJITA Tomonori
2005-11-01  2:04   ` FUJITA Tomonori
2005-11-01  4:55   ` Roland Dreier
2005-11-01  4:55     ` Roland Dreier
2005-11-01  4:58     ` [openib-general] " Christoph Hellwig
2005-11-01  5:03       ` Roland Dreier [this message]
2005-11-01  5:03         ` Roland Dreier
2005-11-01  5:04         ` Christoph Hellwig
2005-11-01  5:04           ` [openib-general] " Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52acgpgdso.fsf@cisco.com \
    --to=rolandd@cisco.com \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=openib-general@openib.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.