* NR_IRQS and possible irq values on malta
@ 2005-02-03 22:26 Guy Streeter
2005-02-03 22:45 ` Maciej W. Rozycki
0 siblings, 1 reply; 2+ messages in thread
From: Guy Streeter @ 2005-02-03 22:26 UTC (permalink / raw)
To: linux-mips
In mips_pcibios_iack() the irq number is obtained like this:
irq = GT_READ(GT_PCI0_IACK_OFS);
irq &= 0xff;
(for coreLV, but similarly for others). This value is used to index
into an array of size NR_IRQS, which is set in mach-generic/irq.h to
128.
I realize that when things work right, the value of irq isn't likely
to get that big, but it seems to me it should be masked down to 127 or
the NR_IRQS value should be larger. I have no opinion which is the
right thing to do.
--Guy
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: NR_IRQS and possible irq values on malta
2005-02-03 22:26 NR_IRQS and possible irq values on malta Guy Streeter
@ 2005-02-03 22:45 ` Maciej W. Rozycki
0 siblings, 0 replies; 2+ messages in thread
From: Maciej W. Rozycki @ 2005-02-03 22:45 UTC (permalink / raw)
To: Guy Streeter; +Cc: linux-mips
On Thu, 3 Feb 2005, Guy Streeter wrote:
> In mips_pcibios_iack() the irq number is obtained like this:
>
> irq = GT_READ(GT_PCI0_IACK_OFS);
> irq &= 0xff;
>
> (for coreLV, but similarly for others). This value is used to index
> into an array of size NR_IRQS, which is set in mach-generic/irq.h to
> 128.
> I realize that when things work right, the value of irq isn't likely
> to get that big, but it seems to me it should be masked down to 127 or
> the NR_IRQS value should be larger. I have no opinion which is the
> right thing to do.
It looks like a problem in __do_IRQ() (in kernel/irq/handle.c) -- it
should probably call "BUG_ON(irq >= NR_IRQS)". MIPS-specific code doesn't
care.
Maciej
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-02-03 22:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-03 22:26 NR_IRQS and possible irq values on malta Guy Streeter
2005-02-03 22:45 ` Maciej W. Rozycki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.