From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, Andi Shyti <andi@etezian.org>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] i915/gem_exec_nop: Keep a copy of the names
Date: Tue, 11 Feb 2020 13:00:19 +0000 [thread overview]
Message-ID: <52e2f277-e709-05b2-d66a-833fe8b234f1@linux.intel.com> (raw)
In-Reply-To: <158141747934.5235.15646593670790864278@skylake-alporthouse-com>
On 11/02/2020 10:37, Chris Wilson wrote:
> Quoting Andi Shyti (2020-02-11 00:42:55)
>> Hi Chris,
>>
>> On Tue, Feb 11, 2020 at 12:37:42AM +0000, Chris Wilson wrote:
>>> The engine names are now stored inside the iterator and not as static
>>> strings. If we wish to use them later, we need to make a copy.
>>
>> But we are not using them later. Your patch just copies and frees
>> an array.
>
> They are used inside an igt_info() in the child processes. Output at the
> moment is quite strange.
I also don't get this - child has a copy of everything how can it not work?
Regards,
Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
WARNING: multiple messages have this Message-ID (diff)
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, Andi Shyti <andi@etezian.org>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_exec_nop: Keep a copy of the names
Date: Tue, 11 Feb 2020 13:00:19 +0000 [thread overview]
Message-ID: <52e2f277-e709-05b2-d66a-833fe8b234f1@linux.intel.com> (raw)
In-Reply-To: <158141747934.5235.15646593670790864278@skylake-alporthouse-com>
On 11/02/2020 10:37, Chris Wilson wrote:
> Quoting Andi Shyti (2020-02-11 00:42:55)
>> Hi Chris,
>>
>> On Tue, Feb 11, 2020 at 12:37:42AM +0000, Chris Wilson wrote:
>>> The engine names are now stored inside the iterator and not as static
>>> strings. If we wish to use them later, we need to make a copy.
>>
>> But we are not using them later. Your patch just copies and frees
>> an array.
>
> They are used inside an igt_info() in the child processes. Output at the
> moment is quite strange.
I also don't get this - child has a copy of everything how can it not work?
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-11 13:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 0:37 [igt-dev] [PATCH i-g-t] i915/gem_exec_nop: Keep a copy of the names Chris Wilson
2020-02-11 0:37 ` [Intel-gfx] " Chris Wilson
2020-02-11 0:42 ` Andi Shyti
2020-02-11 10:37 ` [igt-dev] " Chris Wilson
2020-02-11 10:37 ` Chris Wilson
2020-02-11 13:00 ` Tvrtko Ursulin [this message]
2020-02-11 13:00 ` [Intel-gfx] [igt-dev] " Tvrtko Ursulin
2020-02-11 13:05 ` [igt-dev] [Intel-gfx] " Chris Wilson
2020-02-11 13:05 ` [Intel-gfx] [igt-dev] " Chris Wilson
2020-02-11 13:21 ` [igt-dev] [Intel-gfx] " Tvrtko Ursulin
2020-02-11 13:21 ` [Intel-gfx] [igt-dev] " Tvrtko Ursulin
2020-02-11 1:36 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-02-12 13:52 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52e2f277-e709-05b2-d66a-833fe8b234f1@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=andi@etezian.org \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.