All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yijing Wang <wangyijing@huawei.com>
To: Liviu Dudau <Liviu.Dudau@arm.com>,
	linux-pci <linux-pci@vger.kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Catalin Marinas <Catalin.Marinas@arm.com>,
	Will Deacon <Will.Deacon@arm.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	LAKML <linux-arm-kernel@lists.infradead.org>,
	linaro-kernel <linaro-kernel@lists.linaro.org>,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] arm64: Add architecture support for PCI
Date: Tue, 18 Feb 2014 14:33:53 +0800	[thread overview]
Message-ID: <5302FED1.80903@huawei.com> (raw)
In-Reply-To: <1391453028-23191-2-git-send-email-Liviu.Dudau@arm.com>

> +#include <linux/init.h>
> +#include <linux/io.h>
> +#include <linux/kernel.h>
> +#include <linux/mm.h>
> +#include <linux/of_pci.h>
> +#include <linux/of_platform.h>
> +#include <linux/slab.h>
> +
> +#include <asm/pci-bridge.h>
> +
> +
> +/*
> + * Return the domain number for this bus
> + */
> +int pci_domain_nr(struct pci_bus *bus)
> +{
> +	struct pci_host_bridge *bridge = to_pci_host_bridge(bus->bridge);

Here bus is specific to root bus ? or, what about use find_pci_host_bridge() to get the pci_host_bridge
instead.

> +
> +	if (bridge)
> +		return bridge->domain_nr;
> +
> +	return 0;
> +}
> +
> +int pci_proc_domain(struct pci_bus *bus)
> +{
> +	return pci_domain_nr(bus);
> +}
> +
> +/*
> + * Called after each bus is probed, but before its children are examined
> + */
> +void pcibios_fixup_bus(struct pci_bus *bus)
> +{
> +	struct pci_dev *dev;
> +	struct resource *res;
> +	int i;
> +
> +	if (bus->self != NULL) {

What about use !pci_is_root_bus() ?

> +		pci_read_bridge_bases(bus);
> +
> +		pci_bus_for_each_resource(bus, res, i) {
> +			if (!res || !res->flags || res->parent)
> +				continue;
> +
> +			/*
> +			 * If we are going to reassign everything, we can
> +			 * shrink the P2P resource to have zero size to
> +			 * save space
> +			 */
> +			if (pci_has_flag(PCI_REASSIGN_ALL_RSRC)) {
> +				res->flags |= IORESOURCE_UNSET;
> +				res->start = 0;
> +				res->end = -1;
> +				continue;
> +			}
> +		}
> +	}
> +


WARNING: multiple messages have this Message-ID (diff)
From: wangyijing@huawei.com (Yijing Wang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: Add architecture support for PCI
Date: Tue, 18 Feb 2014 14:33:53 +0800	[thread overview]
Message-ID: <5302FED1.80903@huawei.com> (raw)
In-Reply-To: <1391453028-23191-2-git-send-email-Liviu.Dudau@arm.com>

> +#include <linux/init.h>
> +#include <linux/io.h>
> +#include <linux/kernel.h>
> +#include <linux/mm.h>
> +#include <linux/of_pci.h>
> +#include <linux/of_platform.h>
> +#include <linux/slab.h>
> +
> +#include <asm/pci-bridge.h>
> +
> +
> +/*
> + * Return the domain number for this bus
> + */
> +int pci_domain_nr(struct pci_bus *bus)
> +{
> +	struct pci_host_bridge *bridge = to_pci_host_bridge(bus->bridge);

Here bus is specific to root bus ? or, what about use find_pci_host_bridge() to get the pci_host_bridge
instead.

> +
> +	if (bridge)
> +		return bridge->domain_nr;
> +
> +	return 0;
> +}
> +
> +int pci_proc_domain(struct pci_bus *bus)
> +{
> +	return pci_domain_nr(bus);
> +}
> +
> +/*
> + * Called after each bus is probed, but before its children are examined
> + */
> +void pcibios_fixup_bus(struct pci_bus *bus)
> +{
> +	struct pci_dev *dev;
> +	struct resource *res;
> +	int i;
> +
> +	if (bus->self != NULL) {

What about use !pci_is_root_bus() ?

> +		pci_read_bridge_bases(bus);
> +
> +		pci_bus_for_each_resource(bus, res, i) {
> +			if (!res || !res->flags || res->parent)
> +				continue;
> +
> +			/*
> +			 * If we are going to reassign everything, we can
> +			 * shrink the P2P resource to have zero size to
> +			 * save space
> +			 */
> +			if (pci_has_flag(PCI_REASSIGN_ALL_RSRC)) {
> +				res->flags |= IORESOURCE_UNSET;
> +				res->start = 0;
> +				res->end = -1;
> +				continue;
> +			}
> +		}
> +	}
> +

  parent reply	other threads:[~2014-02-18  6:34 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-03 18:43 [PATCH] [RFC] Add AArch64 support for PCI Liviu Dudau
2014-02-03 18:43 ` Liviu Dudau
2014-02-03 18:43 ` Liviu Dudau
2014-02-03 18:43 ` [PATCH] arm64: Add architecture " Liviu Dudau
2014-02-03 18:43   ` Liviu Dudau
2014-02-03 18:58   ` Arnd Bergmann
2014-02-03 18:58     ` Arnd Bergmann
2014-02-03 19:18     ` Liviu Dudau
2014-02-03 19:18       ` Liviu Dudau
2014-02-03 19:21       ` kodiak furr
2014-02-03 20:05       ` Arnd Bergmann
2014-02-03 20:05         ` Arnd Bergmann
2014-02-03 21:36         ` Liviu Dudau
2014-02-03 21:36           ` Liviu Dudau
2014-02-04  8:44           ` Arnd Bergmann
2014-02-04  8:44             ` Arnd Bergmann
2014-02-04 11:09             ` Liviu Dudau
2014-02-04 11:09               ` Liviu Dudau
2014-02-04 11:54               ` Arnd Bergmann
2014-02-04 11:54                 ` Arnd Bergmann
2014-02-04 11:54                 ` Arnd Bergmann
2014-02-04 16:41             ` Catalin Marinas
2014-02-04 16:41               ` Catalin Marinas
2014-02-03 23:07         ` Rob Herring
2014-02-03 23:07           ` Rob Herring
2014-02-03 23:31           ` Jason Gunthorpe
2014-02-03 23:31             ` Jason Gunthorpe
2014-02-04  9:44             ` Arnd Bergmann
2014-02-04  9:44               ` Arnd Bergmann
2014-02-04  9:44               ` Arnd Bergmann
2014-02-04 13:57               ` Rob Herring
2014-02-04 13:57                 ` Rob Herring
2014-02-04 19:50                 ` Arnd Bergmann
2014-02-04 19:50                   ` Arnd Bergmann
2014-02-04 19:50                   ` Arnd Bergmann
2014-02-04 18:15               ` Jason Gunthorpe
2014-02-04 18:15                 ` Jason Gunthorpe
2014-02-04 18:34                 ` Arnd Bergmann
2014-02-04 18:34                   ` Arnd Bergmann
2014-02-04 18:34                   ` Arnd Bergmann
2014-02-04 19:10                   ` Jason Gunthorpe
2014-02-04 19:10                     ` Jason Gunthorpe
2014-02-04 19:21                     ` Arnd Bergmann
2014-02-04 19:21                       ` Arnd Bergmann
2014-02-04  9:01           ` Arnd Bergmann
2014-02-04  9:01             ` Arnd Bergmann
2014-02-03 22:34   ` Andrew Murray
2014-02-03 22:34     ` Andrew Murray
2014-02-03 22:34     ` Andrew Murray
2014-02-04 12:29     ` Liviu Dudau
2014-02-04 12:29       ` Liviu Dudau
2014-02-04 13:23       ` Andrew Murray
2014-02-04 13:23         ` Andrew Murray
2014-02-04 16:18         ` Arnd Bergmann
2014-02-04 16:18           ` Arnd Bergmann
2014-02-04 16:18           ` Arnd Bergmann
2014-02-18  6:33   ` Yijing Wang [this message]
2014-02-18  6:33     ` Yijing Wang
2014-02-20 14:38     ` Liviu Dudau
2014-02-20 14:38       ` Liviu Dudau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5302FED1.80903@huawei.com \
    --to=wangyijing@huawei.com \
    --cc=Catalin.Marinas@arm.com \
    --cc=Liviu.Dudau@arm.com \
    --cc=Will.Deacon@arm.com \
    --cc=arnd@arndb.de \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.