Re: [Qemu-devel] [PATCH] kvm: fix kvm_set_migration_log() behavior

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1012 bytes --]

On 02/18/2014 05:33 AM, Vincent KHERBACHE wrote:
> The test (!!(mem->flags & KVM_MEM_LOG_DIRTY_PAGES) == enable) is wrong because 
> the condition is valid when enable = 0 and current dirty log memory flag is set.
> As a consequence kvm_log_global_stop() does not stop the KVM dirty log
> tracking: kvm_set_migration_log(0) didn't do its job.
> So instead I propose to use kvm_slot_dirty_pages_log_change() which correctly
> compare the memory flags (old/new).
> 
> Signed-off-by: Vincent KHERBACHE <vincent.kherbache@inria.fr>
> ---
>  kvm-all.c | 12 +++---------
>  1 file changed, 3 insertions(+), 9 deletions(-)
> 

> -            return err;
> -        }
> +        err = kvm_slot_dirty_pages_log_change(mem, (bool)enable);

Is this a v2 post?  Any reason you reposted without addressing my
earlier review?
https://lists.gnu.org/archive/html/qemu-devel/2014-02/msg02840.html

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]