Re: [Qemu-devel] [PATCH] kvm: fix kvm_set_migration_log() behavior

[Vincent KHERBACHE <vincent.kherbache@inria.fr>]

Le 18/02/2014 14:23, Eric Blake a écrit :
>> -            return err;
>> -        }
>> +        err = kvm_slot_dirty_pages_log_change(mem, (bool)enable);
> 
> Is this a v2 post?  Any reason you reposted without addressing my
> earlier review?
> https://lists.gnu.org/archive/html/qemu-devel/2014-02/msg02840.html

My bad, I apologize for the duplicate post I just missed your review.

>> +        err = kvm_slot_dirty_pages_log_change(mem, (bool)enable);
>
> Casting to bool looks odd.  We already require a compliant C99 compiler,
> which means the compiler already properly handles the squashing of all
> non-zero values to true when calling a function with a parameter
> prototyped as bool, without needing the cast.

Thanks for information, here is the patch without the useless casting.

BR.

Signed-off-by: Vincent KHERBACHE <vincent.kherbache@inria.fr>
---
 kvm-all.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/kvm-all.c b/kvm-all.c
index 2ca9143..007df56 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -355,7 +355,7 @@ static int kvm_set_migration_log(int enable)
 {
     KVMState *s = kvm_state;
     KVMSlot *mem;
-    int i, err;
+    int i, err = 0;

     s->migration_log = enable;

@@ -365,15 +365,9 @@ static int kvm_set_migration_log(int enable)
         if (!mem->memory_size) {
             continue;
         }
-        if (!!(mem->flags & KVM_MEM_LOG_DIRTY_PAGES) == enable) {
-            continue;
-        }
-        err = kvm_set_user_memory_region(s, mem);
-        if (err) {
-            return err;
-        }
+        err = kvm_slot_dirty_pages_log_change(mem, enable);
     }
-    return 0;
+    return err;
 }

 /* get kvm's dirty pages bitmap and update qemu's */
---
Vincent KHERBACHE