* [PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t'
@ 2014-02-18 12:23 Fabio Estevam
2014-02-18 16:32 ` Guenter Roeck
` (3 more replies)
0 siblings, 4 replies; 13+ messages in thread
From: Fabio Estevam @ 2014-02-18 12:23 UTC (permalink / raw)
To: wim; +Cc: olof, festevam, linux-watchdog, Fabio Estevam
When building an ARM multi_v7_defconfig with LPAE option selected we get the
following build warning:
drivers/watchdog/orion_wdt.c:272:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=]
Fix it by using %pa to print 'phys_addr_t'.
Reported-by: Olof's autobuilder <build@lixom.net>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/watchdog/orion_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/orion_wdt.c b/drivers/watchdog/orion_wdt.c
index 15321aa..6f9b4c6 100644
--- a/drivers/watchdog/orion_wdt.c
+++ b/drivers/watchdog/orion_wdt.c
@@ -269,7 +269,7 @@ static void __iomem *orion_wdt_ioremap_rstout(struct platform_device *pdev,
rstout = internal_regs + ORION_RSTOUT_MASK_OFFSET;
- WARN(1, FW_BUG "falling back to harcoded RSTOUT reg 0x%x\n", rstout);
+ WARN(1, FW_BUG "falling back to harcoded RSTOUT reg %pa\n", &rstout);
return devm_ioremap(&pdev->dev, rstout, 0x4);
}
--
1.8.1.2
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t' 2014-02-18 12:23 [PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t' Fabio Estevam @ 2014-02-18 16:32 ` Guenter Roeck 2014-02-18 17:47 ` Ezequiel Garcia ` (2 subsequent siblings) 3 siblings, 0 replies; 13+ messages in thread From: Guenter Roeck @ 2014-02-18 16:32 UTC (permalink / raw) To: Fabio Estevam, wim; +Cc: olof, festevam, linux-watchdog On 02/18/2014 04:23 AM, Fabio Estevam wrote: > When building an ARM multi_v7_defconfig with LPAE option selected we get the > following build warning: > > drivers/watchdog/orion_wdt.c:272:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=] > > Fix it by using %pa to print 'phys_addr_t'. > > Reported-by: Olof's autobuilder <build@lixom.net> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t' 2014-02-18 12:23 [PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t' Fabio Estevam 2014-02-18 16:32 ` Guenter Roeck @ 2014-02-18 17:47 ` Ezequiel Garcia 2014-02-19 16:59 ` Wim Van Sebroeck 2014-02-24 20:33 ` Wim Van Sebroeck 3 siblings, 0 replies; 13+ messages in thread From: Ezequiel Garcia @ 2014-02-18 17:47 UTC (permalink / raw) To: Fabio Estevam; +Cc: wim, olof, festevam, linux-watchdog On Tue, Feb 18, 2014 at 09:23:54AM -0300, Fabio Estevam wrote: > When building an ARM multi_v7_defconfig with LPAE option selected we get the > following build warning: > > drivers/watchdog/orion_wdt.c:272:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=] > > Fix it by using %pa to print 'phys_addr_t'. > > Reported-by: Olof's autobuilder <build@lixom.net> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> Acked-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> -- Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t' 2014-02-18 12:23 [PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t' Fabio Estevam 2014-02-18 16:32 ` Guenter Roeck 2014-02-18 17:47 ` Ezequiel Garcia @ 2014-02-19 16:59 ` Wim Van Sebroeck 2014-02-19 18:54 ` Ezequiel Garcia 2014-02-24 20:33 ` Wim Van Sebroeck 3 siblings, 1 reply; 13+ messages in thread From: Wim Van Sebroeck @ 2014-02-19 16:59 UTC (permalink / raw) To: Fabio Estevam, Jason Cooper, Ezequiel Garcia Cc: olof, festevam, linux-watchdog Hi Ezequiel, Can you have a look at the below patch? Kind regards, Wim. > When building an ARM multi_v7_defconfig with LPAE option selected we get the > following build warning: > > drivers/watchdog/orion_wdt.c:272:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=] > > Fix it by using %pa to print 'phys_addr_t'. > > Reported-by: Olof's autobuilder <build@lixom.net> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- > drivers/watchdog/orion_wdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/orion_wdt.c b/drivers/watchdog/orion_wdt.c > index 15321aa..6f9b4c6 100644 > --- a/drivers/watchdog/orion_wdt.c > +++ b/drivers/watchdog/orion_wdt.c > @@ -269,7 +269,7 @@ static void __iomem *orion_wdt_ioremap_rstout(struct platform_device *pdev, > > rstout = internal_regs + ORION_RSTOUT_MASK_OFFSET; > > - WARN(1, FW_BUG "falling back to harcoded RSTOUT reg 0x%x\n", rstout); > + WARN(1, FW_BUG "falling back to harcoded RSTOUT reg %pa\n", &rstout); > return devm_ioremap(&pdev->dev, rstout, 0x4); > } > > -- > 1.8.1.2 > > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t' 2014-02-19 16:59 ` Wim Van Sebroeck @ 2014-02-19 18:54 ` Ezequiel Garcia 2014-02-24 20:10 ` Wim Van Sebroeck 0 siblings, 1 reply; 13+ messages in thread From: Ezequiel Garcia @ 2014-02-19 18:54 UTC (permalink / raw) To: Wim Van Sebroeck Cc: Fabio Estevam, Jason Cooper, olof, festevam, linux-watchdog On Wed, Feb 19, 2014 at 05:59:33PM +0100, Wim Van Sebroeck wrote: > > Can you have a look at the below patch? > I've acked-it yesterday, I think. Do you want me to re-send the mail? -- Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t' 2014-02-19 18:54 ` Ezequiel Garcia @ 2014-02-24 20:10 ` Wim Van Sebroeck 0 siblings, 0 replies; 13+ messages in thread From: Wim Van Sebroeck @ 2014-02-24 20:10 UTC (permalink / raw) To: Ezequiel Garcia Cc: Fabio Estevam, Jason Cooper, olof, festevam, linux-watchdog Hi Ezequiel, > On Wed, Feb 19, 2014 at 05:59:33PM +0100, Wim Van Sebroeck wrote: > > > > Can you have a look at the below patch? > > > > I've acked-it yesterday, I think. > > Do you want me to re-send the mail? Not needed :-). I have it. Kind regards, Wim. ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t' 2014-02-18 12:23 [PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t' Fabio Estevam ` (2 preceding siblings ...) 2014-02-19 16:59 ` Wim Van Sebroeck @ 2014-02-24 20:33 ` Wim Van Sebroeck 2014-02-25 15:09 ` Ezequiel Garcia 3 siblings, 1 reply; 13+ messages in thread From: Wim Van Sebroeck @ 2014-02-24 20:33 UTC (permalink / raw) To: Fabio Estevam; +Cc: olof, festevam, linux-watchdog Hi All, > When building an ARM multi_v7_defconfig with LPAE option selected we get the > following build warning: > > drivers/watchdog/orion_wdt.c:272:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=] > > Fix it by using %pa to print 'phys_addr_t'. > > Reported-by: Olof's autobuilder <build@lixom.net> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- > drivers/watchdog/orion_wdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/orion_wdt.c b/drivers/watchdog/orion_wdt.c > index 15321aa..6f9b4c6 100644 > --- a/drivers/watchdog/orion_wdt.c > +++ b/drivers/watchdog/orion_wdt.c > @@ -269,7 +269,7 @@ static void __iomem *orion_wdt_ioremap_rstout(struct platform_device *pdev, > > rstout = internal_regs + ORION_RSTOUT_MASK_OFFSET; > > - WARN(1, FW_BUG "falling back to harcoded RSTOUT reg 0x%x\n", rstout); > + WARN(1, FW_BUG "falling back to harcoded RSTOUT reg %pa\n", &rstout); > return devm_ioremap(&pdev->dev, rstout, 0x4); > } > > -- > 1.8.1.2 > > Acked-by me also, but can this also go via the mvebu tree (since the patch that introduces this is also thereà? Kind regards, Wim. ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t' 2014-02-24 20:33 ` Wim Van Sebroeck @ 2014-02-25 15:09 ` Ezequiel Garcia 0 siblings, 0 replies; 13+ messages in thread From: Ezequiel Garcia @ 2014-02-25 15:09 UTC (permalink / raw) To: Jason Cooper Cc: Fabio Estevam, olof, festevam, linux-watchdog, linux-arm-kernel, Wim Van Sebroeck Jason, On Mon, Feb 24, 2014 at 09:33:52PM +0100, Wim Van Sebroeck wrote: > > When building an ARM multi_v7_defconfig with LPAE option selected we get the > > following build warning: > > > > drivers/watchdog/orion_wdt.c:272:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=] > > > > Fix it by using %pa to print 'phys_addr_t'. > > > > Reported-by: Olof's autobuilder <build@lixom.net> > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > > --- > > drivers/watchdog/orion_wdt.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/watchdog/orion_wdt.c b/drivers/watchdog/orion_wdt.c > > index 15321aa..6f9b4c6 100644 > > --- a/drivers/watchdog/orion_wdt.c > > +++ b/drivers/watchdog/orion_wdt.c > > @@ -269,7 +269,7 @@ static void __iomem *orion_wdt_ioremap_rstout(struct platform_device *pdev, > > > > rstout = internal_regs + ORION_RSTOUT_MASK_OFFSET; > > > > - WARN(1, FW_BUG "falling back to harcoded RSTOUT reg 0x%x\n", rstout); > > + WARN(1, FW_BUG "falling back to harcoded RSTOUT reg %pa\n", &rstout); > > return devm_ioremap(&pdev->dev, rstout, 0x4); > > } > > > > -- > > 1.8.1.2 > > > > > > Acked-by me also, but can this also go via the mvebu tree (since the patch that introduces this is also thereà? > Can you pull this too? It's been acked by Wim and me. Thanks, -- Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t' @ 2014-02-25 15:09 ` Ezequiel Garcia 0 siblings, 0 replies; 13+ messages in thread From: Ezequiel Garcia @ 2014-02-25 15:09 UTC (permalink / raw) To: linux-arm-kernel Jason, On Mon, Feb 24, 2014 at 09:33:52PM +0100, Wim Van Sebroeck wrote: > > When building an ARM multi_v7_defconfig with LPAE option selected we get the > > following build warning: > > > > drivers/watchdog/orion_wdt.c:272:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=] > > > > Fix it by using %pa to print 'phys_addr_t'. > > > > Reported-by: Olof's autobuilder <build@lixom.net> > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > > --- > > drivers/watchdog/orion_wdt.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/watchdog/orion_wdt.c b/drivers/watchdog/orion_wdt.c > > index 15321aa..6f9b4c6 100644 > > --- a/drivers/watchdog/orion_wdt.c > > +++ b/drivers/watchdog/orion_wdt.c > > @@ -269,7 +269,7 @@ static void __iomem *orion_wdt_ioremap_rstout(struct platform_device *pdev, > > > > rstout = internal_regs + ORION_RSTOUT_MASK_OFFSET; > > > > - WARN(1, FW_BUG "falling back to harcoded RSTOUT reg 0x%x\n", rstout); > > + WARN(1, FW_BUG "falling back to harcoded RSTOUT reg %pa\n", &rstout); > > return devm_ioremap(&pdev->dev, rstout, 0x4); > > } > > > > -- > > 1.8.1.2 > > > > > > Acked-by me also, but can this also go via the mvebu tree (since the patch that introduces this is also there?? > Can you pull this too? It's been acked by Wim and me. Thanks, -- Ezequiel Garc?a, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t' 2014-02-25 15:09 ` Ezequiel Garcia @ 2014-02-25 16:07 ` Jason Cooper -1 siblings, 0 replies; 13+ messages in thread From: Jason Cooper @ 2014-02-25 16:07 UTC (permalink / raw) To: Ezequiel Garcia Cc: Fabio Estevam, olof, festevam, linux-watchdog, linux-arm-kernel, Wim Van Sebroeck On Tue, Feb 25, 2014 at 12:09:48PM -0300, Ezequiel Garcia wrote: > Jason, > > On Mon, Feb 24, 2014 at 09:33:52PM +0100, Wim Van Sebroeck wrote: > > > When building an ARM multi_v7_defconfig with LPAE option selected we get the > > > following build warning: > > > > > > drivers/watchdog/orion_wdt.c:272:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=] > > > > > > Fix it by using %pa to print 'phys_addr_t'. > > > > > > Reported-by: Olof's autobuilder <build@lixom.net> > > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > > > --- > > > drivers/watchdog/orion_wdt.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/watchdog/orion_wdt.c b/drivers/watchdog/orion_wdt.c > > > index 15321aa..6f9b4c6 100644 > > > --- a/drivers/watchdog/orion_wdt.c > > > +++ b/drivers/watchdog/orion_wdt.c > > > @@ -269,7 +269,7 @@ static void __iomem *orion_wdt_ioremap_rstout(struct platform_device *pdev, > > > > > > rstout = internal_regs + ORION_RSTOUT_MASK_OFFSET; > > > > > > - WARN(1, FW_BUG "falling back to harcoded RSTOUT reg 0x%x\n", rstout); > > > + WARN(1, FW_BUG "falling back to harcoded RSTOUT reg %pa\n", &rstout); > > > return devm_ioremap(&pdev->dev, rstout, 0x4); > > > } > > > > > > -- > > > 1.8.1.2 > > > > > > > > > > Acked-by me also, but can this also go via the mvebu tree (since the patch that introduces this is also thereà? > > > > Can you pull this too? It's been acked by Wim and me. Yep, I'll add it onto the stack. thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t' @ 2014-02-25 16:07 ` Jason Cooper 0 siblings, 0 replies; 13+ messages in thread From: Jason Cooper @ 2014-02-25 16:07 UTC (permalink / raw) To: linux-arm-kernel On Tue, Feb 25, 2014 at 12:09:48PM -0300, Ezequiel Garcia wrote: > Jason, > > On Mon, Feb 24, 2014 at 09:33:52PM +0100, Wim Van Sebroeck wrote: > > > When building an ARM multi_v7_defconfig with LPAE option selected we get the > > > following build warning: > > > > > > drivers/watchdog/orion_wdt.c:272:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=] > > > > > > Fix it by using %pa to print 'phys_addr_t'. > > > > > > Reported-by: Olof's autobuilder <build@lixom.net> > > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > > > --- > > > drivers/watchdog/orion_wdt.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/watchdog/orion_wdt.c b/drivers/watchdog/orion_wdt.c > > > index 15321aa..6f9b4c6 100644 > > > --- a/drivers/watchdog/orion_wdt.c > > > +++ b/drivers/watchdog/orion_wdt.c > > > @@ -269,7 +269,7 @@ static void __iomem *orion_wdt_ioremap_rstout(struct platform_device *pdev, > > > > > > rstout = internal_regs + ORION_RSTOUT_MASK_OFFSET; > > > > > > - WARN(1, FW_BUG "falling back to harcoded RSTOUT reg 0x%x\n", rstout); > > > + WARN(1, FW_BUG "falling back to harcoded RSTOUT reg %pa\n", &rstout); > > > return devm_ioremap(&pdev->dev, rstout, 0x4); > > > } > > > > > > -- > > > 1.8.1.2 > > > > > > > > > > Acked-by me also, but can this also go via the mvebu tree (since the patch that introduces this is also there?? > > > > Can you pull this too? It's been acked by Wim and me. Yep, I'll add it onto the stack. thx, Jason. ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t' 2014-02-25 15:09 ` Ezequiel Garcia @ 2014-02-25 16:10 ` Jason Cooper -1 siblings, 0 replies; 13+ messages in thread From: Jason Cooper @ 2014-02-25 16:10 UTC (permalink / raw) To: Ezequiel Garcia Cc: Fabio Estevam, olof, festevam, linux-watchdog, linux-arm-kernel, Wim Van Sebroeck Fabio, On Tue, Feb 25, 2014 at 12:09:48PM -0300, Ezequiel Garcia wrote: > Jason, > > On Mon, Feb 24, 2014 at 09:33:52PM +0100, Wim Van Sebroeck wrote: > > > When building an ARM multi_v7_defconfig with LPAE option selected we get the > > > following build warning: > > > > > > drivers/watchdog/orion_wdt.c:272:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=] > > > > > > Fix it by using %pa to print 'phys_addr_t'. > > > > > > Reported-by: Olof's autobuilder <build@lixom.net> > > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > > > --- > > > drivers/watchdog/orion_wdt.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/watchdog/orion_wdt.c b/drivers/watchdog/orion_wdt.c > > > index 15321aa..6f9b4c6 100644 > > > --- a/drivers/watchdog/orion_wdt.c > > > +++ b/drivers/watchdog/orion_wdt.c > > > @@ -269,7 +269,7 @@ static void __iomem *orion_wdt_ioremap_rstout(struct platform_device *pdev, > > > > > > rstout = internal_regs + ORION_RSTOUT_MASK_OFFSET; > > > > > > - WARN(1, FW_BUG "falling back to harcoded RSTOUT reg 0x%x\n", rstout); > > > + WARN(1, FW_BUG "falling back to harcoded RSTOUT reg %pa\n", &rstout); > > > return devm_ioremap(&pdev->dev, rstout, 0x4); > > > } > > > > > > -- > > > 1.8.1.2 > > > > > > > > > > Acked-by me also, but can this also go via the mvebu tree (since the patch that introduces this is also thereà? > > > > Can you pull this too? It's been acked by Wim and me. I don't have a local archive of the watchdog ML, could you resend the patch to me? thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t' @ 2014-02-25 16:10 ` Jason Cooper 0 siblings, 0 replies; 13+ messages in thread From: Jason Cooper @ 2014-02-25 16:10 UTC (permalink / raw) To: linux-arm-kernel Fabio, On Tue, Feb 25, 2014 at 12:09:48PM -0300, Ezequiel Garcia wrote: > Jason, > > On Mon, Feb 24, 2014 at 09:33:52PM +0100, Wim Van Sebroeck wrote: > > > When building an ARM multi_v7_defconfig with LPAE option selected we get the > > > following build warning: > > > > > > drivers/watchdog/orion_wdt.c:272:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=] > > > > > > Fix it by using %pa to print 'phys_addr_t'. > > > > > > Reported-by: Olof's autobuilder <build@lixom.net> > > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > > > --- > > > drivers/watchdog/orion_wdt.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/watchdog/orion_wdt.c b/drivers/watchdog/orion_wdt.c > > > index 15321aa..6f9b4c6 100644 > > > --- a/drivers/watchdog/orion_wdt.c > > > +++ b/drivers/watchdog/orion_wdt.c > > > @@ -269,7 +269,7 @@ static void __iomem *orion_wdt_ioremap_rstout(struct platform_device *pdev, > > > > > > rstout = internal_regs + ORION_RSTOUT_MASK_OFFSET; > > > > > > - WARN(1, FW_BUG "falling back to harcoded RSTOUT reg 0x%x\n", rstout); > > > + WARN(1, FW_BUG "falling back to harcoded RSTOUT reg %pa\n", &rstout); > > > return devm_ioremap(&pdev->dev, rstout, 0x4); > > > } > > > > > > -- > > > 1.8.1.2 > > > > > > > > > > Acked-by me also, but can this also go via the mvebu tree (since the patch that introduces this is also there?? > > > > Can you pull this too? It's been acked by Wim and me. I don't have a local archive of the watchdog ML, could you resend the patch to me? thx, Jason. ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2014-02-25 16:10 UTC | newest] Thread overview: 13+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-02-18 12:23 [PATCH] watchdog: orion_wdt: Use %pa to print 'phys_addr_t' Fabio Estevam 2014-02-18 16:32 ` Guenter Roeck 2014-02-18 17:47 ` Ezequiel Garcia 2014-02-19 16:59 ` Wim Van Sebroeck 2014-02-19 18:54 ` Ezequiel Garcia 2014-02-24 20:10 ` Wim Van Sebroeck 2014-02-24 20:33 ` Wim Van Sebroeck 2014-02-25 15:09 ` Ezequiel Garcia 2014-02-25 15:09 ` Ezequiel Garcia 2014-02-25 16:07 ` Jason Cooper 2014-02-25 16:07 ` Jason Cooper 2014-02-25 16:10 ` Jason Cooper 2014-02-25 16:10 ` Jason Cooper
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.