All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Riemer <sebastian.riemer-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
To: Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>,
	"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: IB/srp: merge fixes from MLNX_OFED
Date: Tue, 18 Feb 2014 17:47:15 +0100	[thread overview]
Message-ID: <53038E93.7050706@profitbricks.com> (raw)

Hi Sagi,

is that "/mswg/git/mlnx_ofed/mlnx-ofed-2.x-kernel.git" tree from the
MLNX_OFED public by any chance?

There are fixes included relevant for the mainline. Would be strange if
I would send the patches as somebody at Mellanox discovered and fixed
the issues.

I've hit a kernel panic today during testing caused by the loop around
ib_fmr_pool_unmap(). The loop has been fixed in MLNX_OFED. So there
should be a patch sent for it to the linux-rdma mailing list.

I've also noticed the added target locking around target->free_tx
handling in srp_rport_reconnect(). There are cases e.g. in
srp_queuecommand() where holding the rport mutex isn't enough to protect
it. So for me this looks right.

Then, in srp_create_target() I've noticed the check of the return value
of ib_query_gid(). Makes completely sense to check it.

Please send patches for so obvious fixes to the mailing list! There is a
very good chance that they get accepted.

Cheers,
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2014-02-18 16:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-18 16:47 Sebastian Riemer [this message]
     [not found] ` <53038E93.7050706-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2014-02-18 17:05   ` IB/srp: merge fixes from MLNX_OFED Bart Van Assche
     [not found]     ` <530392D9.1010900-HInyCGIudOg@public.gmane.org>
2014-02-18 17:25       ` Sagi Grimberg
     [not found]         ` <53039779.3080507-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2014-02-18 17:42           ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53038E93.7050706@profitbricks.com \
    --to=sebastian.riemer-eikl63zcoxah+58jc4qpia@public.gmane.org \
    --cc=bvanassche-HInyCGIudOg@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.