All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>
To: Sebastian Riemer
	<sebastian.riemer-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>,
	Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: IB/srp: merge fixes from MLNX_OFED
Date: Tue, 18 Feb 2014 18:05:29 +0100	[thread overview]
Message-ID: <530392D9.1010900@acm.org> (raw)
In-Reply-To: <53038E93.7050706-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>

On 02/18/14 17:47, Sebastian Riemer wrote:
> I've also noticed the added target locking around target->free_tx
> handling in srp_rport_reconnect(). There are cases e.g. in
> srp_queuecommand() where holding the rport mutex isn't enough to protect
> it. So for me this looks right.
> 
> Then, in srp_create_target() I've noticed the check of the return value
> of ib_query_gid(). Makes completely sense to check it.
> 
> Please send patches for so obvious fixes to the mailing list! There is a
> very good chance that they get accepted.

Hello Sebastian,

If I hadn't been busy testing scsi-mq patches recently, the SRP
initiator patches you referred to would already have been posted for
review on the linux-rdma mailing list. I hope to find some time one of
the next days to post a few SRP initiator patches on the linux-rdma
mailing list - not only the ones referred to above but also a few other
patches.

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2014-02-18 17:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-18 16:47 IB/srp: merge fixes from MLNX_OFED Sebastian Riemer
     [not found] ` <53038E93.7050706-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2014-02-18 17:05   ` Bart Van Assche [this message]
     [not found]     ` <530392D9.1010900-HInyCGIudOg@public.gmane.org>
2014-02-18 17:25       ` Sagi Grimberg
     [not found]         ` <53039779.3080507-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2014-02-18 17:42           ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=530392D9.1010900@acm.org \
    --to=bvanassche-hinycgiudog@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=sebastian.riemer-EIkl63zCoXaH+58JC4qpiA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.