All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Matthew Garrett <matthew.garrett@nebula.com>
Cc: "ibm-acpi-devel@lists.sourceforge.net"
	<ibm-acpi-devel@lists.sourceforge.net>,
	"btissoir@redhat.com" <btissoir@redhat.com>,
	"ibm-acpi@hmh.eng.br" <ibm-acpi@hmh.eng.br>,
	"platform-driver-x86@vger.kernel.org"
	<platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH] thinkpad_acpi: Add mappings for F9 - F12 hotkeys on T440s
Date: Tue, 18 Feb 2014 18:11:06 +0100	[thread overview]
Message-ID: <5303942A.4070602@redhat.com> (raw)
In-Reply-To: <1392739256.29766.2.camel@x230>

Hi,

On 02/18/2014 05:00 PM, Matthew Garrett wrote:
> On Tue, 2014-02-18 at 13:36 +0100, Hans de Goede wrote:
>> /* Extra keys found on the T440(s) */
>> +		KEY_CONFIG, KEY_SEARCH, KEY_SCALE, KEY_COMPUTER,
>
> My recollection is that KEY_SCALE was initially intended for "Toggle
> whether my 640x480 desktop is scaled or letterboxed on my 1280x1024
> display". Is this the most appropriate key?

linux/input.h says:

#define KEY_SCALE		120	/* AL Compiz Scale (Expose) */

And Lenovo describes the purpose of the key as "show all programs"
which is exactly what expose does. With that said I'm open to
suggestions for a better mapping.

Regards,

Hans

      reply	other threads:[~2014-02-18 17:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-18 12:36 [PATCH] thinkpad_acpi: Add mappings for F9 - F12 hotkeys on T440s Hans de Goede
2014-02-18 16:00 ` Matthew Garrett
2014-02-18 17:11   ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5303942A.4070602@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=btissoir@redhat.com \
    --cc=ibm-acpi-devel@lists.sourceforge.net \
    --cc=ibm-acpi@hmh.eng.br \
    --cc=matthew.garrett@nebula.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.