[PATCH] thinkpad_acpi: Add mappings for F9 - F12 hotkeys on T440s

[PATCH] thinkpad_acpi: Add mappings for F9 - F12 hotkeys on T440s

[Hans de Goede]

The T440s user guide says that when Fn-lock is not active, the T440s' F9 - F12
keys should be mapped to: control-panel, search, show-all-windows and Computer.

These keys generate the sofar unused 28 - 31 hotkey scancodes.

For the first 2 this nicely matches the icons on the keys, for the latter 2
the icons are somewhat creative, which is why I ended up looking them up in
the user manual.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/platform/x86/thinkpad_acpi.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index defb6af..ecb4bc2 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -3167,8 +3167,10 @@ static int __init hotkey_init(struct ibm_init_struct *iibm)
 		KEY_MICMUTE,	/* 0x1a: Mic mute (since ?400 or so) */
 
 		/* (assignments unknown, please report if found) */
-		KEY_UNKNOWN, KEY_UNKNOWN, KEY_UNKNOWN, KEY_UNKNOWN,
 		KEY_UNKNOWN,
+
+		/* Extra keys found on the T440(s) */
+		KEY_CONFIG, KEY_SEARCH, KEY_SCALE, KEY_COMPUTER,
 		},
 	};
 
-- 
1.8.5.3

Re: [PATCH] thinkpad_acpi: Add mappings for F9 - F12 hotkeys on T440s

[Matthew Garrett]

On Tue, 2014-02-18 at 13:36 +0100, Hans de Goede wrote:
> /* Extra keys found on the T440(s) */
> +		KEY_CONFIG, KEY_SEARCH, KEY_SCALE, KEY_COMPUTER,

My recollection is that KEY_SCALE was initially intended for "Toggle
whether my 640x480 desktop is scaled or letterboxed on my 1280x1024
display". Is this the most appropriate key?

-- 
Matthew Garrett <matthew.garrett@nebula.com>

Re: [PATCH] thinkpad_acpi: Add mappings for F9 - F12 hotkeys on T440s

[Hans de Goede]

Hi,

On 02/18/2014 05:00 PM, Matthew Garrett wrote:
> On Tue, 2014-02-18 at 13:36 +0100, Hans de Goede wrote:
>> /* Extra keys found on the T440(s) */
>> +		KEY_CONFIG, KEY_SEARCH, KEY_SCALE, KEY_COMPUTER,
>
> My recollection is that KEY_SCALE was initially intended for "Toggle
> whether my 640x480 desktop is scaled or letterboxed on my 1280x1024
> display". Is this the most appropriate key?

linux/input.h says:

#define KEY_SCALE		120	/* AL Compiz Scale (Expose) */

And Lenovo describes the purpose of the key as "show all programs"
which is exactly what expose does. With that said I'm open to
suggestions for a better mapping.

Regards,

Hans