All of lore.kernel.org
 help / color / mirror / Atom feed
From: George Dunlap <george.dunlap@eu.citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xensource.com
Cc: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH] libxl: Properly declare libxlu_disk_l.h in AUTOINCS
Date: Tue, 18 Feb 2014 18:27:20 +0000	[thread overview]
Message-ID: <5303A608.6050704@eu.citrix.com> (raw)
In-Reply-To: <1392743732-23759-1-git-send-email-ian.jackson@eu.citrix.com>

On 02/18/2014 05:15 PM, Ian Jackson wrote:
> This is necessary so that make doesn't do things which depend on this
> file until flex has finished producing it.
>
> Reported-by: Olaf Hering <olaf@aepfle.de>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> CC: Ian Campbell <Ian.Campbell@citrix.com>
> Tested-by: Olaf Hering <olaf@aepfle.de>
> CC: George Dunlap <george.dunlap@eu.citrix.com>

This is a pretty obvious simple fix:

Release-acked-by: George Dunlap <george.dunlap@eu.citrix.com>

> ---
>   tools/libxl/Makefile |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
> index dab2929..755b666 100644
> --- a/tools/libxl/Makefile
> +++ b/tools/libxl/Makefile
> @@ -98,7 +98,7 @@ TEST_PROGS += $(foreach t, $(LIBXL_TESTS),test_$t)
>   $(LIBXL_OBJS) $(LIBXL_TEST_OBJS): CFLAGS += $(CFLAGS_LIBXL) -include $(XEN_ROOT)/tools/config.h
>   
>   AUTOINCS= libxlu_cfg_y.h libxlu_cfg_l.h _libxl_list.h _paths.h \
> -	_libxl_save_msgs_callout.h _libxl_save_msgs_helper.h
> +	libxlu_disk_l.h _libxl_save_msgs_callout.h _libxl_save_msgs_helper.h
>   AUTOSRCS= libxlu_cfg_y.c libxlu_cfg_l.c
>   AUTOSRCS += _libxl_save_msgs_callout.c _libxl_save_msgs_helper.c
>   LIBXLU_OBJS = libxlu_cfg_y.o libxlu_cfg_l.o libxlu_cfg.o \

      parent reply	other threads:[~2014-02-18 18:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-18 17:15 [PATCH] libxl: Properly declare libxlu_disk_l.h in AUTOINCS Ian Jackson
2014-02-18 17:28 ` Ian Campbell
2014-02-18 18:27 ` George Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5303A608.6050704@eu.citrix.com \
    --to=george.dunlap@eu.citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.