* [PATCH] libxl: Properly declare libxlu_disk_l.h in AUTOINCS
@ 2014-02-18 17:15 Ian Jackson
2014-02-18 17:28 ` Ian Campbell
2014-02-18 18:27 ` George Dunlap
0 siblings, 2 replies; 3+ messages in thread
From: Ian Jackson @ 2014-02-18 17:15 UTC (permalink / raw)
To: xen-devel; +Cc: George Dunlap, Ian Jackson, Ian Campbell
This is necessary so that make doesn't do things which depend on this
file until flex has finished producing it.
Reported-by: Olaf Hering <olaf@aepfle.de>
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
CC: Ian Campbell <Ian.Campbell@citrix.com>
Tested-by: Olaf Hering <olaf@aepfle.de>
CC: George Dunlap <george.dunlap@eu.citrix.com>
---
tools/libxl/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
index dab2929..755b666 100644
--- a/tools/libxl/Makefile
+++ b/tools/libxl/Makefile
@@ -98,7 +98,7 @@ TEST_PROGS += $(foreach t, $(LIBXL_TESTS),test_$t)
$(LIBXL_OBJS) $(LIBXL_TEST_OBJS): CFLAGS += $(CFLAGS_LIBXL) -include $(XEN_ROOT)/tools/config.h
AUTOINCS= libxlu_cfg_y.h libxlu_cfg_l.h _libxl_list.h _paths.h \
- _libxl_save_msgs_callout.h _libxl_save_msgs_helper.h
+ libxlu_disk_l.h _libxl_save_msgs_callout.h _libxl_save_msgs_helper.h
AUTOSRCS= libxlu_cfg_y.c libxlu_cfg_l.c
AUTOSRCS += _libxl_save_msgs_callout.c _libxl_save_msgs_helper.c
LIBXLU_OBJS = libxlu_cfg_y.o libxlu_cfg_l.o libxlu_cfg.o \
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] libxl: Properly declare libxlu_disk_l.h in AUTOINCS
2014-02-18 17:15 [PATCH] libxl: Properly declare libxlu_disk_l.h in AUTOINCS Ian Jackson
@ 2014-02-18 17:28 ` Ian Campbell
2014-02-18 18:27 ` George Dunlap
1 sibling, 0 replies; 3+ messages in thread
From: Ian Campbell @ 2014-02-18 17:28 UTC (permalink / raw)
To: Ian Jackson; +Cc: George Dunlap, xen-devel
On Tue, 2014-02-18 at 17:15 +0000, Ian Jackson wrote:
> This is necessary so that make doesn't do things which depend on this
> file until flex has finished producing it.
>
> Reported-by: Olaf Hering <olaf@aepfle.de>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Acked-by: Ian Campbell <Ian.Campbell@citrix.com>
> Tested-by: Olaf Hering <olaf@aepfle.de>
> CC: George Dunlap <george.dunlap@eu.citrix.com>
> ---
> tools/libxl/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
> index dab2929..755b666 100644
> --- a/tools/libxl/Makefile
> +++ b/tools/libxl/Makefile
> @@ -98,7 +98,7 @@ TEST_PROGS += $(foreach t, $(LIBXL_TESTS),test_$t)
> $(LIBXL_OBJS) $(LIBXL_TEST_OBJS): CFLAGS += $(CFLAGS_LIBXL) -include $(XEN_ROOT)/tools/config.h
>
> AUTOINCS= libxlu_cfg_y.h libxlu_cfg_l.h _libxl_list.h _paths.h \
> - _libxl_save_msgs_callout.h _libxl_save_msgs_helper.h
> + libxlu_disk_l.h _libxl_save_msgs_callout.h _libxl_save_msgs_helper.h
> AUTOSRCS= libxlu_cfg_y.c libxlu_cfg_l.c
> AUTOSRCS += _libxl_save_msgs_callout.c _libxl_save_msgs_helper.c
> LIBXLU_OBJS = libxlu_cfg_y.o libxlu_cfg_l.o libxlu_cfg.o \
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libxl: Properly declare libxlu_disk_l.h in AUTOINCS
2014-02-18 17:15 [PATCH] libxl: Properly declare libxlu_disk_l.h in AUTOINCS Ian Jackson
2014-02-18 17:28 ` Ian Campbell
@ 2014-02-18 18:27 ` George Dunlap
1 sibling, 0 replies; 3+ messages in thread
From: George Dunlap @ 2014-02-18 18:27 UTC (permalink / raw)
To: Ian Jackson, xen-devel; +Cc: Ian Campbell
On 02/18/2014 05:15 PM, Ian Jackson wrote:
> This is necessary so that make doesn't do things which depend on this
> file until flex has finished producing it.
>
> Reported-by: Olaf Hering <olaf@aepfle.de>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> CC: Ian Campbell <Ian.Campbell@citrix.com>
> Tested-by: Olaf Hering <olaf@aepfle.de>
> CC: George Dunlap <george.dunlap@eu.citrix.com>
This is a pretty obvious simple fix:
Release-acked-by: George Dunlap <george.dunlap@eu.citrix.com>
> ---
> tools/libxl/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
> index dab2929..755b666 100644
> --- a/tools/libxl/Makefile
> +++ b/tools/libxl/Makefile
> @@ -98,7 +98,7 @@ TEST_PROGS += $(foreach t, $(LIBXL_TESTS),test_$t)
> $(LIBXL_OBJS) $(LIBXL_TEST_OBJS): CFLAGS += $(CFLAGS_LIBXL) -include $(XEN_ROOT)/tools/config.h
>
> AUTOINCS= libxlu_cfg_y.h libxlu_cfg_l.h _libxl_list.h _paths.h \
> - _libxl_save_msgs_callout.h _libxl_save_msgs_helper.h
> + libxlu_disk_l.h _libxl_save_msgs_callout.h _libxl_save_msgs_helper.h
> AUTOSRCS= libxlu_cfg_y.c libxlu_cfg_l.c
> AUTOSRCS += _libxl_save_msgs_callout.c _libxl_save_msgs_helper.c
> LIBXLU_OBJS = libxlu_cfg_y.o libxlu_cfg_l.o libxlu_cfg.o \
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-18 18:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-18 17:15 [PATCH] libxl: Properly declare libxlu_disk_l.h in AUTOINCS Ian Jackson
2014-02-18 17:28 ` Ian Campbell
2014-02-18 18:27 ` George Dunlap
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.