All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@citrix.com>
To: Oleksandr Tyshchenko <oleksandr.tyshchenko@globallogic.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>,
	Andrii Anisov <andrii.anisov@globallogic.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: Bringing up sequence for non-boot CPU fails
Date: Tue, 18 Feb 2014 18:33:48 +0000	[thread overview]
Message-ID: <5303A78C.6090709@citrix.com> (raw)
In-Reply-To: <CAJEb2DFsX81pQzRXoWuanHqj=jFqGdyHsGA3zFGgE0BScdQRsg@mail.gmail.com>

On 02/18/2014 06:17 PM, Oleksandr Tyshchenko wrote:
> Ian,

Hello Oleksandr,

> I have checked your suggestion with full cache flush.
> For this purposes I have used ARMV7 specific function from our U-Boot.
> This function performs clean and invalidation of the entire data cache
> at all levels.

Did you try to only clean the cache? When page table for the secondary
CPU is created Xen only clean the cache for the specific range.
I suspect it's not enough and we need to invalidate.

It should be easy to try with this small patch:

diff --git a/xen/include/asm-arm/page.h b/xen/include/asm-arm/page.h
index e00be9e..5a8aba2 100644
--- a/xen/include/asm-arm/page.h
+++ b/xen/include/asm-arm/page.h
@@ -234,7 +234,7 @@ static inline void clean_xen_dcache_va_range(void
*p, unsigned long size)
     void *end;
     dsb();           /* So the CPU issues all writes to the range */
     for ( end = p + size; p < end; p += cacheline_bytes )
-        asm volatile (__clean_xen_dcache_one(0) : : "r" (p));
+        asm volatile (__clean_and_invalidate_xen_dcache_one(0) : : "r"
(p));
     dsb();           /* So we know the flushes happen before continuing */
 }

Regards,

-- 
Julien Grall

  reply	other threads:[~2014-02-18 18:33 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-18 11:44 Bringing up sequence for non-boot CPU fails Oleksandr Tyshchenko
2014-02-18 12:14 ` Ian Campbell
2014-02-18 12:36   ` Andrii Anisov
2014-02-18 12:53     ` Ian Campbell
2014-02-18 13:23       ` Andrii Anisov
2014-02-18 13:34         ` Ian Campbell
2014-02-18 13:37           ` Andrii Anisov
2014-02-18 15:33             ` Ian Campbell
2014-02-18 18:17               ` Oleksandr Tyshchenko
2014-02-18 18:33                 ` Julien Grall [this message]
2014-02-18 18:40                   ` Oleksandr Tyshchenko
2014-02-19  9:15                   ` Ian Campbell
2014-02-19 12:35                     ` Andrii Anisov
2014-03-01 15:58                       ` Julien Grall
2014-03-04 16:50                         ` Oleksandr Tyshchenko
2014-03-05  1:45                           ` Ian Campbell
2014-02-19  9:04                 ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5303A78C.6090709@citrix.com \
    --to=julien.grall@citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=andrii.anisov@globallogic.com \
    --cc=oleksandr.tyshchenko@globallogic.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.