All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
	David Airlie <airlied@linux.ie>, Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: drm: rcar-du: Document optional reset properties
Date: Fri, 03 Mar 2017 21:17:58 +0200	[thread overview]
Message-ID: <5304812.zzcGWdqkpi@avalon> (raw)
In-Reply-To: <CAMuHMdU=1O_ZZgAXWSecO=HRtZdY8s0LfEMuUkpgvr528HV+Jw@mail.gmail.com>

Hi Geert,

On Friday 03 Mar 2017 20:03:09 Geert Uytterhoeven wrote:
> On Fri, Mar 3, 2017 at 3:41 PM, Laurent Pinchart wrote:
> > On Friday 03 Mar 2017 14:30:35 Geert Uytterhoeven wrote:
> >> Document the optional properties for describing module resets, to
> >> support resetting display channels and LVDS encoders on R-Car Gen2 and
> >> Gen3.
> >> 
> >> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >> ---
> >> 
> >>  Documentation/devicetree/bindings/display/renesas,du.txt | 10 ++++++++++
> >>  1 file changed, 10 insertions(+)
> >> 
> >> diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt
> >> b/Documentation/devicetree/bindings/display/renesas,du.txt index
> >> 1a02f099a0ff0a3a..7873d53764a297c2 100644
> >> --- a/Documentation/devicetree/bindings/display/renesas,du.txt
> >> +++ b/Documentation/devicetree/bindings/display/renesas,du.txt
> >> 
> >> @@ -36,6 +36,16 @@ Required Properties:
> >>        When supplied they must be named "dclkin.x" with "x" being the
> >>        input clock numerical index.
> >> 
> >> +Optional properties:
> >> +  - resets: A list of phandles + reset-specifier pairs, one for each
> >> entry in
> > 
> > s/phandlers/phandle/
> 
> You're seeing typos that do not exist ;-)
> 
> >> +    the reset-names property.
> > 
> > What's in the reset specifier ?
> 
> That depends on the reset provider.
> 
> See "[v2,1/4] dt-bindings: clock: renesas: cpg-mssr: Document reset control
> support" (https://patchwork.kernel.org/patch/9536627/) for the Renesas
> CPG/MSSR case.
> 
> E.g. "resets = <&cpg 310>;"

Thanks. I never know whether the specified is the combination of phandle + 
data, or is only the cells following the phandle.

-- 
Regards,

Laurent Pinchart

WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH] dt-bindings: drm: rcar-du: Document optional reset properties
Date: Fri, 03 Mar 2017 21:17:58 +0200	[thread overview]
Message-ID: <5304812.zzcGWdqkpi@avalon> (raw)
In-Reply-To: <CAMuHMdU=1O_ZZgAXWSecO=HRtZdY8s0LfEMuUkpgvr528HV+Jw@mail.gmail.com>

Hi Geert,

On Friday 03 Mar 2017 20:03:09 Geert Uytterhoeven wrote:
> On Fri, Mar 3, 2017 at 3:41 PM, Laurent Pinchart wrote:
> > On Friday 03 Mar 2017 14:30:35 Geert Uytterhoeven wrote:
> >> Document the optional properties for describing module resets, to
> >> support resetting display channels and LVDS encoders on R-Car Gen2 and
> >> Gen3.
> >> 
> >> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >> ---
> >> 
> >>  Documentation/devicetree/bindings/display/renesas,du.txt | 10 ++++++++++
> >>  1 file changed, 10 insertions(+)
> >> 
> >> diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt
> >> b/Documentation/devicetree/bindings/display/renesas,du.txt index
> >> 1a02f099a0ff0a3a..7873d53764a297c2 100644
> >> --- a/Documentation/devicetree/bindings/display/renesas,du.txt
> >> +++ b/Documentation/devicetree/bindings/display/renesas,du.txt
> >> 
> >> @@ -36,6 +36,16 @@ Required Properties:
> >>        When supplied they must be named "dclkin.x" with "x" being the
> >>        input clock numerical index.
> >> 
> >> +Optional properties:
> >> +  - resets: A list of phandles + reset-specifier pairs, one for each
> >> entry in
> > 
> > s/phandlers/phandle/
> 
> You're seeing typos that do not exist ;-)
> 
> >> +    the reset-names property.
> > 
> > What's in the reset specifier ?
> 
> That depends on the reset provider.
> 
> See "[v2,1/4] dt-bindings: clock: renesas: cpg-mssr: Document reset control
> support" (https://patchwork.kernel.org/patch/9536627/) for the Renesas
> CPG/MSSR case.
> 
> E.g. "resets = <&cpg 310>;"

Thanks. I never know whether the specified is the combination of phandle + 
data, or is only the cells following the phandle.

-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2017-03-03 19:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-03 13:30 [PATCH] dt-bindings: drm: rcar-du: Document optional reset properties Geert Uytterhoeven
2017-03-03 14:41 ` Laurent Pinchart
2017-03-03 14:41   ` Laurent Pinchart
2017-03-03 19:03   ` Geert Uytterhoeven
2017-03-03 19:03     ` Geert Uytterhoeven
2017-03-03 19:04     ` Geert Uytterhoeven
2017-03-03 19:04       ` Geert Uytterhoeven
2017-03-03 19:15       ` Laurent Pinchart
2017-03-03 19:15         ` Laurent Pinchart
2017-03-03 19:17     ` Laurent Pinchart [this message]
2017-03-03 19:17       ` Laurent Pinchart
2017-03-03 19:23       ` Geert Uytterhoeven
2017-03-03 19:23         ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5304812.zzcGWdqkpi@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=airlied@linux.ie \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert+renesas@glider.be \
    --cc=geert@linux-m68k.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.