From: klightspeed@killerwolves.net (Ben Peddell)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 4/5] ARM: Kirkwood: Fix qnap vendor prefix
Date: Wed, 19 Feb 2014 23:14:16 +1000 [thread overview]
Message-ID: <5304AE28.6030209@killerwolves.net> (raw)
In-Reply-To: <20140219130553.GO17984@lunn.ch>
On 19/02/14 23:05, Andrew Lunn wrote:
>> diff --git a/drivers/power/reset/qnap-poweroff.c b/drivers/power/reset/qnap-poweroff.c
>> index a75db7f..d350ece 100644
>> --- a/drivers/power/reset/qnap-poweroff.c
>> +++ b/drivers/power/reset/qnap-poweroff.c
>> @@ -41,7 +41,7 @@ static const struct power_off_cfg synology_power_off_cfg = {
>> };
>>
>> static const struct of_device_id qnap_power_off_of_match_table[] = {
>> - { .compatible = "qnap,power-off",
>> + { .compatible = "qnapsz,power-off",
>> .data = &qnap_power_off_cfg,
>> },
>
> Hi Ben
>
> This causes issues for devices using old DT blobs. You need to keep
> the old entry as well as supporting the new vendor prefix.
>
> We need to consider, is it worth the hassle of changing the prefix,
> since it has been in use for a long time. I think using the stock
> ticker is a "rule of thumb" and not a strict requirement.
So, in this case it would be best to change qnapsz back to qnap in
patch #1, and completely remove this patch?
WARNING: multiple messages have this Message-ID (diff)
From: Ben Peddell <klightspeed-aslSrjg9ejhWX4hkXwHRhw@public.gmane.org>
To: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Dmitry Eremin-Solenikov
<dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Anton Vorontsov <anton-9xeibp6oKSgdnm+yROfE0A@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v5 4/5] ARM: Kirkwood: Fix qnap vendor prefix
Date: Wed, 19 Feb 2014 23:14:16 +1000 [thread overview]
Message-ID: <5304AE28.6030209@killerwolves.net> (raw)
In-Reply-To: <20140219130553.GO17984-g2DYL2Zd6BY@public.gmane.org>
On 19/02/14 23:05, Andrew Lunn wrote:
>> diff --git a/drivers/power/reset/qnap-poweroff.c b/drivers/power/reset/qnap-poweroff.c
>> index a75db7f..d350ece 100644
>> --- a/drivers/power/reset/qnap-poweroff.c
>> +++ b/drivers/power/reset/qnap-poweroff.c
>> @@ -41,7 +41,7 @@ static const struct power_off_cfg synology_power_off_cfg = {
>> };
>>
>> static const struct of_device_id qnap_power_off_of_match_table[] = {
>> - { .compatible = "qnap,power-off",
>> + { .compatible = "qnapsz,power-off",
>> .data = &qnap_power_off_cfg,
>> },
>
> Hi Ben
>
> This causes issues for devices using old DT blobs. You need to keep
> the old entry as well as supporting the new vendor prefix.
>
> We need to consider, is it worth the hassle of changing the prefix,
> since it has been in use for a long time. I think using the stock
> ticker is a "rule of thumb" and not a strict requirement.
So, in this case it would be best to change qnapsz back to qnap in
patch #1, and completely remove this patch?
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-02-19 13:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 12:49 [PATCH v5 0/5] DT support for kirkwood based Synology NAS boxes klightspeed at killerwolves.net
2014-02-19 12:49 ` klightspeed-aslSrjg9ejhWX4hkXwHRhw
2014-02-19 12:49 ` [PATCH v5 1/5] DT: Vendor prefixes: Add ricoh, qnap, sii and synology klightspeed at killerwolves.net
2014-02-19 12:49 ` klightspeed-aslSrjg9ejhWX4hkXwHRhw
2014-02-19 12:49 ` [PATCH v5 2/5] Power: Reset: Generalize qnap-poweroff to work on Synology devices klightspeed at killerwolves.net
2014-02-19 12:49 ` klightspeed-aslSrjg9ejhWX4hkXwHRhw
2014-02-19 12:49 ` [PATCH v5 3/5] DT: i2c: Trivial: Add sii, s35390a, fix ricoh vendor prefix klightspeed at killerwolves.net
2014-02-19 12:49 ` klightspeed-aslSrjg9ejhWX4hkXwHRhw
2014-02-19 12:49 ` [PATCH v5 4/5] ARM: Kirkwood: Fix qnap " klightspeed at killerwolves.net
2014-02-19 12:49 ` klightspeed-aslSrjg9ejhWX4hkXwHRhw
2014-02-19 12:59 ` David Woodhouse
2014-02-19 12:59 ` David Woodhouse
2014-02-19 13:05 ` Andrew Lunn
2014-02-19 13:05 ` Andrew Lunn
2014-02-19 13:14 ` Ben Peddell [this message]
2014-02-19 13:14 ` Ben Peddell
2014-02-19 17:10 ` Mark Rutland
2014-02-19 17:10 ` Mark Rutland
2014-02-19 12:49 ` [PATCH v5 5/5] ARM: Kirkwood: Add support for many Synology NAS devices klightspeed at killerwolves.net
2014-02-19 12:49 ` klightspeed-aslSrjg9ejhWX4hkXwHRhw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5304AE28.6030209@killerwolves.net \
--to=klightspeed@killerwolves.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.