From: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>
To: Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: David Dillow <dave-i1Mk8JYDVaaSihdK6806/g@public.gmane.org>,
Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Vu Pham <vuhuong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Sebastian Riemer
<sebastian.riemer-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>,
linux-rdma <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: [PATCH 3/6] IB/srp: Fail SCSI commands silently
Date: Thu, 20 Feb 2014 11:52:23 +0100 [thread overview]
Message-ID: <5305DE67.9070805@acm.org> (raw)
In-Reply-To: <5305DE01.7030004-HInyCGIudOg@public.gmane.org>
Do not log SCSI command failures that are the result of a transport
layer failure, a SCSI abort or SCSI reset. This patch is a slightly
modified version of a patch posted by Sebastian Riemer in March 2013
(see also http://thread.gmane.org/gmane.linux.drivers.rdma/15020/).
This patch avoids that a system becomes unresponsive during failover
of a large number of LUNs when kernel messages are logged to a serial
console.
Signed-off-by: Sebastian Riemer <sebastian.riemer-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
Signed-off-by: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>
Cc: Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
drivers/infiniband/ulp/srp/ib_srp.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c
index fba52d2..b3ca4d6 100644
--- a/drivers/infiniband/ulp/srp/ib_srp.c
+++ b/drivers/infiniband/ulp/srp/ib_srp.c
@@ -827,6 +827,7 @@ static void srp_finish_req(struct srp_target_port *target,
if (scmnd) {
srp_free_req(target, req, scmnd, 0);
+ scmnd->request->cmd_flags |= REQ_QUIET;
scmnd->result = result;
scmnd->scsi_done(scmnd);
}
@@ -1517,6 +1518,7 @@ static int srp_queuecommand(struct Scsi_Host *shost, struct scsi_cmnd *scmnd)
result = srp_chkready(target->rport);
if (unlikely(result)) {
+ scmnd->request->cmd_flags |= REQ_QUIET;
scmnd->result = result;
scmnd->scsi_done(scmnd);
goto unlock_rport;
@@ -2011,6 +2013,7 @@ static int srp_abort(struct scsi_cmnd *scmnd)
else
ret = FAILED;
srp_free_req(target, req, scmnd, 0);
+ scmnd->request->cmd_flags |= REQ_QUIET;
scmnd->result = DID_ABORT << 16;
scmnd->scsi_done(scmnd);
--
1.8.4.5
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-02-20 10:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 10:50 [PATCH 0/6] SRP initiator patches for kernel 3.15 Bart Van Assche
[not found] ` <5305DE01.7030004-HInyCGIudOg@public.gmane.org>
2014-02-20 10:51 ` [PATCH 1/6] scsi_transport_srp: Fix two kernel-doc warnings Bart Van Assche
[not found] ` <5305DE2C.4080203-HInyCGIudOg@public.gmane.org>
2014-02-20 12:01 ` Sebastian Riemer
2014-02-20 10:52 ` Bart Van Assche [this message]
[not found] ` <5305DE67.9070805-HInyCGIudOg@public.gmane.org>
2014-02-20 10:57 ` [PATCH 3/6] IB/srp: Fail SCSI commands silently Bart Van Assche
2014-02-21 3:55 ` David Dillow
[not found] ` <1392954937.26557.3.camel-a7a0dvSY7KqLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
2014-02-21 9:23 ` Bart Van Assche
[not found] ` <53071B2E.2050302-HInyCGIudOg@public.gmane.org>
2014-02-22 5:41 ` David Dillow
[not found] ` <1393047697.12377.11.camel-a7a0dvSY7KqLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
2014-02-24 19:58 ` Bart Van Assche
[not found] ` <530BA476.7040005-HInyCGIudOg@public.gmane.org>
2014-02-25 4:36 ` David Dillow
[not found] ` <1393302995.9096.1.camel-a7a0dvSY7KqLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
2014-02-25 10:33 ` Bart Van Assche
[not found] ` <530C7175.5060907-HInyCGIudOg@public.gmane.org>
2014-02-26 6:32 ` David Dillow
[not found] ` <1393396377.12328.5.camel-a7a0dvSY7KqLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
2014-02-26 13:16 ` Bart Van Assche
[not found] ` <530DE93A.2040400-HInyCGIudOg@public.gmane.org>
2014-02-27 5:48 ` David Dillow
[not found] ` <1393480118.16410.10.camel-a7a0dvSY7KqLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
2014-02-27 13:44 ` Bart Van Assche
2014-02-20 10:53 ` [PATCH 4/6] IB/srp: Avoid duplicate connections Bart Van Assche
2014-02-20 10:54 ` [PATCH 5/6] IB/srp: Make writing into the "add_target" sysfs attribute interruptible Bart Van Assche
2014-02-20 10:55 ` [PATCH 6/6] IB/srp: Avoid that writing into "add_target" hangs due to a cable pull Bart Van Assche
2014-02-20 10:56 ` [PATCH 2/6] IB/srp: Add more logging Bart Van Assche
2014-02-21 3:36 ` [PATCH 0/6] SRP initiator patches for kernel 3.15 Vasiliy Tolstov
[not found] ` <CACaajQt5FVw-8rVhM1jwZPORGNdrAkTf-Gi3NdkKRnQaYde48Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-02-21 12:20 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5305DE67.9070805@acm.org \
--to=bvanassche-hinycgiudog@public.gmane.org \
--cc=dave-i1Mk8JYDVaaSihdK6806/g@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=sebastian.riemer-EIkl63zCoXaH+58JC4qpiA@public.gmane.org \
--cc=vuhuong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.