From: Sebastian Riemer <sebastian.riemer-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
To: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>
Cc: Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
David Dillow <dave-i1Mk8JYDVaaSihdK6806/g@public.gmane.org>,
Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Vu Pham <vuhuong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
James Bottomley
<jbottomley-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>,
Masanari Iida
<standby24x7-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-rdma <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 1/6] scsi_transport_srp: Fix two kernel-doc warnings
Date: Thu, 20 Feb 2014 13:01:41 +0100 [thread overview]
Message-ID: <5305EEA5.8090802@profitbricks.com> (raw)
In-Reply-To: <5305DE2C.4080203-HInyCGIudOg@public.gmane.org>
On 20.02.2014 11:51, Bart Van Assche wrote:
> This patch fixes the following two kernel-doc warnings:
>
> Warning(drivers/scsi/scsi_transport_srp.c:819): No description found for parameter 'rport'
> Warning(include/scsi/scsi_transport_srp.h:75): Excess struct/union/enum/typedef member 'deleted' description in 'srp_rport'
>
> Signed-off-by: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>
> Reported-by: Masanari Iida <standby24x7-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Cc: Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Cc: Sebastian Riemer <sebastian.riemer-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
> Cc: James Bottomley <jbottomley-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
> Cc: Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> ---
> drivers/scsi/scsi_transport_srp.c | 1 +
> include/scsi/scsi_transport_srp.h | 1 -
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_transport_srp.c b/drivers/scsi/scsi_transport_srp.c
> index d47ffc8..13e8983 100644
> --- a/drivers/scsi/scsi_transport_srp.c
> +++ b/drivers/scsi/scsi_transport_srp.c
> @@ -810,6 +810,7 @@ EXPORT_SYMBOL_GPL(srp_remove_host);
>
> /**
> * srp_stop_rport_timers - stop the transport layer recovery timers
> + * @rport: SRP remote port for which to stop the timers.
> *
> * Must be called after srp_remove_host() and scsi_remove_host(). The caller
> * must hold a reference on the rport (rport->dev) and on the SCSI host
> diff --git a/include/scsi/scsi_transport_srp.h b/include/scsi/scsi_transport_srp.h
> index b11da5c..cdb05dd 100644
> --- a/include/scsi/scsi_transport_srp.h
> +++ b/include/scsi/scsi_transport_srp.h
> @@ -41,7 +41,6 @@ enum srp_rport_state {
> * @mutex: Protects against concurrent rport reconnect /
> * fast_io_fail / dev_loss_tmo activity.
> * @state: rport state.
> - * @deleted: Whether or not srp_rport_del() has already been invoked.
> * @reconnect_delay: Reconnect delay in seconds.
> * @failed_reconnects: Number of failed reconnect attempts.
> * @reconnect_work: Work structure used for scheduling reconnect attempts.
>
This is trivial. Thanks!
Acked-by: Sebastian Riemer <sebastian.riemer-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-02-20 12:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 10:50 [PATCH 0/6] SRP initiator patches for kernel 3.15 Bart Van Assche
[not found] ` <5305DE01.7030004-HInyCGIudOg@public.gmane.org>
2014-02-20 10:51 ` [PATCH 1/6] scsi_transport_srp: Fix two kernel-doc warnings Bart Van Assche
[not found] ` <5305DE2C.4080203-HInyCGIudOg@public.gmane.org>
2014-02-20 12:01 ` Sebastian Riemer [this message]
2014-02-20 10:52 ` [PATCH 3/6] IB/srp: Fail SCSI commands silently Bart Van Assche
[not found] ` <5305DE67.9070805-HInyCGIudOg@public.gmane.org>
2014-02-20 10:57 ` Bart Van Assche
2014-02-21 3:55 ` David Dillow
[not found] ` <1392954937.26557.3.camel-a7a0dvSY7KqLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
2014-02-21 9:23 ` Bart Van Assche
[not found] ` <53071B2E.2050302-HInyCGIudOg@public.gmane.org>
2014-02-22 5:41 ` David Dillow
[not found] ` <1393047697.12377.11.camel-a7a0dvSY7KqLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
2014-02-24 19:58 ` Bart Van Assche
[not found] ` <530BA476.7040005-HInyCGIudOg@public.gmane.org>
2014-02-25 4:36 ` David Dillow
[not found] ` <1393302995.9096.1.camel-a7a0dvSY7KqLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
2014-02-25 10:33 ` Bart Van Assche
[not found] ` <530C7175.5060907-HInyCGIudOg@public.gmane.org>
2014-02-26 6:32 ` David Dillow
[not found] ` <1393396377.12328.5.camel-a7a0dvSY7KqLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
2014-02-26 13:16 ` Bart Van Assche
[not found] ` <530DE93A.2040400-HInyCGIudOg@public.gmane.org>
2014-02-27 5:48 ` David Dillow
[not found] ` <1393480118.16410.10.camel-a7a0dvSY7KqLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
2014-02-27 13:44 ` Bart Van Assche
2014-02-20 10:53 ` [PATCH 4/6] IB/srp: Avoid duplicate connections Bart Van Assche
2014-02-20 10:54 ` [PATCH 5/6] IB/srp: Make writing into the "add_target" sysfs attribute interruptible Bart Van Assche
2014-02-20 10:55 ` [PATCH 6/6] IB/srp: Avoid that writing into "add_target" hangs due to a cable pull Bart Van Assche
2014-02-20 10:56 ` [PATCH 2/6] IB/srp: Add more logging Bart Van Assche
2014-02-21 3:36 ` [PATCH 0/6] SRP initiator patches for kernel 3.15 Vasiliy Tolstov
[not found] ` <CACaajQt5FVw-8rVhM1jwZPORGNdrAkTf-Gi3NdkKRnQaYde48Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-02-21 12:20 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5305EEA5.8090802@profitbricks.com \
--to=sebastian.riemer-eikl63zcoxah+58jc4qpia@public.gmane.org \
--cc=bvanassche-HInyCGIudOg@public.gmane.org \
--cc=dave-i1Mk8JYDVaaSihdK6806/g@public.gmane.org \
--cc=jbottomley-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=standby24x7-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=vuhuong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.