From: Stefan Weil <sw@weilnetz.de>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] trace: Fix build warnings for Win32 build
Date: Thu, 20 Feb 2014 22:41:39 +0100 [thread overview]
Message-ID: <53067693.6030304@weilnetz.de> (raw)
In-Reply-To: <1392925465-14498-1-git-send-email-peter.maydell@linaro.org>
Am 20.02.2014 20:44, schrieb Peter Maydell:
> The Win32 build warns about trace/control-internal.h:
>
> warning: 'trace_event_count' declared inline after being called
>
> Fix this by simply reordering trace_event_id() and
> trace_event_count().
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> trace/control-internal.h | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Stefan Weil <sw@weilnetz.de>
This is not OS specific, but depends on the compiler. MinGW-w64 uses a
newer gcc which does not complain. Reordering the two function is
reasonable nevertheless.
Regards
Stefan
next prev parent reply other threads:[~2014-02-20 21:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 19:44 [Qemu-devel] [PATCH] trace: Fix build warnings for Win32 build Peter Maydell
2014-02-20 21:41 ` Stefan Weil [this message]
2014-02-21 10:07 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53067693.6030304@weilnetz.de \
--to=sw@weilnetz.de \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.