All of lore.kernel.org
 help / color / mirror / Atom feed
From: s.nawrocki@samsung.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] phy: restrict Samsung S5P/Exynos drivers to the respective architectures
Date: Fri, 21 Feb 2014 16:55:51 +0100	[thread overview]
Message-ID: <53077707.9060409@samsung.com> (raw)
In-Reply-To: <1392991526-20895-1-git-send-email-u.kleine-koenig@pengutronix.de>

Hi,

On 21/02/14 15:05, Uwe Kleine-K?nig wrote:
> Enabling these drivers on platforms not created by Samsung is useless
> unless you're doing compile tests. So don't offer the users to enable
> them without COMPILE_TEST for configs with S5P/Exynos disabled.

Thanks for the patch, I've already sent something similar to Kishon, but
I've messed up the mailing list address. A bit improved v2 I just posted
can be found here:

https://patchwork.kernel.org/patch/3698271/
https://patchwork.kernel.org/patch/3698251/

> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/phy/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index c7a551c2d5f1..82a98f1a5ec2 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -18,6 +18,7 @@ config GENERIC_PHY
>  config PHY_EXYNOS_MIPI_VIDEO
>  	depends on HAS_IOMEM
>  	tristate "S5P/EXYNOS SoC series MIPI CSI-2/DSI PHY driver"
> +	depends on PLAT_S5P || ARCH_EXYNOS || COMPILE_TEST
>  	help
>  	  Support for MIPI CSI-2 and MIPI DSI DPHY found on Samsung S5P
>  	  and EXYNOS SoCs.
> @@ -54,6 +55,7 @@ config TWL4030_USB
>  config PHY_EXYNOS_DP_VIDEO
>  	tristate "EXYNOS SoC series Display Port PHY driver"
>  	depends on OF
> +	depends on ARCH_EXYNOS || COMPILE_TEST
>  	select GENERIC_PHY
>  	help
>  	  Support for Display Port PHY found on Samsung EXYNOS SoCs.
> 

Regards,
Sylwester

WARNING: multiple messages have this Message-ID (diff)
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Jingoo Han <jg1.han@samsung.com>,
	Tomasz Figa <t.figa@samsung.com>, Felipe Balbi <balbi@ti.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de
Subject: Re: [PATCH] phy: restrict Samsung S5P/Exynos drivers to the respective architectures
Date: Fri, 21 Feb 2014 16:55:51 +0100	[thread overview]
Message-ID: <53077707.9060409@samsung.com> (raw)
In-Reply-To: <1392991526-20895-1-git-send-email-u.kleine-koenig@pengutronix.de>

Hi,

On 21/02/14 15:05, Uwe Kleine-König wrote:
> Enabling these drivers on platforms not created by Samsung is useless
> unless you're doing compile tests. So don't offer the users to enable
> them without COMPILE_TEST for configs with S5P/Exynos disabled.

Thanks for the patch, I've already sent something similar to Kishon, but
I've messed up the mailing list address. A bit improved v2 I just posted
can be found here:

https://patchwork.kernel.org/patch/3698271/
https://patchwork.kernel.org/patch/3698251/

> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/phy/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index c7a551c2d5f1..82a98f1a5ec2 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -18,6 +18,7 @@ config GENERIC_PHY
>  config PHY_EXYNOS_MIPI_VIDEO
>  	depends on HAS_IOMEM
>  	tristate "S5P/EXYNOS SoC series MIPI CSI-2/DSI PHY driver"
> +	depends on PLAT_S5P || ARCH_EXYNOS || COMPILE_TEST
>  	help
>  	  Support for MIPI CSI-2 and MIPI DSI DPHY found on Samsung S5P
>  	  and EXYNOS SoCs.
> @@ -54,6 +55,7 @@ config TWL4030_USB
>  config PHY_EXYNOS_DP_VIDEO
>  	tristate "EXYNOS SoC series Display Port PHY driver"
>  	depends on OF
> +	depends on ARCH_EXYNOS || COMPILE_TEST
>  	select GENERIC_PHY
>  	help
>  	  Support for Display Port PHY found on Samsung EXYNOS SoCs.
> 

Regards,
Sylwester

  parent reply	other threads:[~2014-02-21 15:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-21 14:05 [PATCH] phy: restrict Samsung S5P/Exynos drivers to the respective architectures Uwe Kleine-König
2014-02-21 14:05 ` Uwe Kleine-König
2014-02-21 15:31 ` Felipe Balbi
2014-02-21 15:31   ` Felipe Balbi
2014-02-21 15:55 ` Sylwester Nawrocki [this message]
2014-02-21 15:55   ` Sylwester Nawrocki
2014-02-21 19:09   ` Uwe Kleine-König
2014-02-21 19:09     ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53077707.9060409@samsung.com \
    --to=s.nawrocki@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.