From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Arnd Bergmann <arnd@arndb.de>, linux-arm-kernel@lists.infradead.org
Cc: kishon@ti.com, linux-samsung-soc@vger.kernel.org,
jg1.han@samsung.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] phy: Select PHY_EXYNOS_DP_VIDEO by default for ARCH_EXYNOS
Date: Fri, 21 Feb 2014 17:25:04 +0100 [thread overview]
Message-ID: <53077DE0.7080108@samsung.com> (raw)
In-Reply-To: <1753680.KKj0Q1erxA@wuerfel>
On 21/02/14 16:59, Arnd Bergmann wrote:
> On Friday 21 February 2014 16:50:02 Sylwester Nawrocki wrote:
>> config PHY_EXYNOS_DP_VIDEO
>> tristate "EXYNOS SoC series Display Port PHY driver"
>> depends on OF
>> + depends on ARCH_EXYNOS || COMPILE_TEST
>> + default y
>> select GENERIC_PHY
>> help
>>
>
> That would turn them on automatically if you enable COMPILE_TEST, which
> is probably not what you want.
>
> How about "default ARCH_EXYNOS"?
Hmm, good point, I will modify it that way.
For patch 1/2 I guess it should be:
"default ARCH_S5PV210 || ARCH_EXYNOS"
or rather
"default y if ARCH_S5PV210 || ARCH_EXYNOS" ?
Thanks,
Sylwester
WARNING: multiple messages have this Message-ID (diff)
From: s.nawrocki@samsung.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] phy: Select PHY_EXYNOS_DP_VIDEO by default for ARCH_EXYNOS
Date: Fri, 21 Feb 2014 17:25:04 +0100 [thread overview]
Message-ID: <53077DE0.7080108@samsung.com> (raw)
In-Reply-To: <1753680.KKj0Q1erxA@wuerfel>
On 21/02/14 16:59, Arnd Bergmann wrote:
> On Friday 21 February 2014 16:50:02 Sylwester Nawrocki wrote:
>> config PHY_EXYNOS_DP_VIDEO
>> tristate "EXYNOS SoC series Display Port PHY driver"
>> depends on OF
>> + depends on ARCH_EXYNOS || COMPILE_TEST
>> + default y
>> select GENERIC_PHY
>> help
>>
>
> That would turn them on automatically if you enable COMPILE_TEST, which
> is probably not what you want.
>
> How about "default ARCH_EXYNOS"?
Hmm, good point, I will modify it that way.
For patch 1/2 I guess it should be:
"default ARCH_S5PV210 || ARCH_EXYNOS"
or rather
"default y if ARCH_S5PV210 || ARCH_EXYNOS" ?
Thanks,
Sylwester
next prev parent reply other threads:[~2014-02-21 16:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 15:50 [PATCH v2 1/2] phy: Select PHY_EXYNOS_MIPI_VIDEO by default for ARCH_EXYNOS Sylwester Nawrocki
2014-02-21 15:50 ` Sylwester Nawrocki
2014-02-21 15:50 ` [PATCH v2 2/2] phy: Select PHY_EXYNOS_DP_VIDEO " Sylwester Nawrocki
2014-02-21 15:50 ` Sylwester Nawrocki
2014-02-21 15:59 ` Arnd Bergmann
2014-02-21 15:59 ` Arnd Bergmann
2014-02-21 16:25 ` Sylwester Nawrocki [this message]
2014-02-21 16:25 ` Sylwester Nawrocki
2014-02-21 16:41 ` Arnd Bergmann
2014-02-21 16:41 ` Arnd Bergmann
2014-02-21 16:41 ` Arnd Bergmann
2014-02-21 16:50 ` Sylwester Nawrocki
2014-02-21 16:50 ` Sylwester Nawrocki
2014-02-21 17:54 ` Arnd Bergmann
2014-02-21 17:54 ` Arnd Bergmann
2014-02-21 17:54 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53077DE0.7080108@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=arnd@arndb.de \
--cc=jg1.han@samsung.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.