From: Richard Henderson <rth@twiddle.net>
To: Stefan Weil <sw@weilnetz.de>, qemu-trivial@nongnu.org
Cc: Andrzej Zaborowski <balrogg@gmail.com>,
Claudio Fontana <claudio.fontana@huawei.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] tcg: Fix warning (1 bit signed bitfield entry) and replace int by bool
Date: Fri, 21 Feb 2014 13:10:06 -0600 [thread overview]
Message-ID: <5307A48E.2030700@twiddle.net> (raw)
In-Reply-To: <1393003115-9801-1-git-send-email-sw@weilnetz.de>
On 02/21/2014 11:18 AM, Stefan Weil wrote:
> Static code analyzers complain about signed bitfields with only a single
> bit. is_ld is used as a boolean value, so make it bool.
>
> ppc64 already used bool for the 2nd argument is_ld of the local function
> add_qemu_ldst_label. Modify all other TCG targets to do follow this
> example.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> tcg/aarch64/tcg-target.c | 6 +++---
> tcg/arm/tcg-target.c | 6 +++---
> tcg/i386/tcg-target.c | 6 +++---
> tcg/ppc/tcg-target.c | 6 +++---
> tcg/tcg-be-ldst.h | 2 +-
> 5 files changed, 13 insertions(+), 13 deletions(-)
Applied to a tcg-next tree.
r~
WARNING: multiple messages have this Message-ID (diff)
From: Richard Henderson <rth@twiddle.net>
To: Stefan Weil <sw@weilnetz.de>, qemu-trivial@nongnu.org
Cc: Claudio Fontana <claudio.fontana@huawei.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] tcg: Fix warning (1 bit signed bitfield entry) and replace int by bool
Date: Fri, 21 Feb 2014 13:10:06 -0600 [thread overview]
Message-ID: <5307A48E.2030700@twiddle.net> (raw)
In-Reply-To: <1393003115-9801-1-git-send-email-sw@weilnetz.de>
On 02/21/2014 11:18 AM, Stefan Weil wrote:
> Static code analyzers complain about signed bitfields with only a single
> bit. is_ld is used as a boolean value, so make it bool.
>
> ppc64 already used bool for the 2nd argument is_ld of the local function
> add_qemu_ldst_label. Modify all other TCG targets to do follow this
> example.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> tcg/aarch64/tcg-target.c | 6 +++---
> tcg/arm/tcg-target.c | 6 +++---
> tcg/i386/tcg-target.c | 6 +++---
> tcg/ppc/tcg-target.c | 6 +++---
> tcg/tcg-be-ldst.h | 2 +-
> 5 files changed, 13 insertions(+), 13 deletions(-)
Applied to a tcg-next tree.
r~
next prev parent reply other threads:[~2014-02-21 19:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 17:18 [Qemu-trivial] [PATCH] tcg: Fix warning (1 bit signed bitfield entry) and replace int by bool Stefan Weil
2014-02-21 17:18 ` [Qemu-devel] " Stefan Weil
2014-02-21 19:10 ` Richard Henderson [this message]
2014-02-21 19:10 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5307A48E.2030700@twiddle.net \
--to=rth@twiddle.net \
--cc=balrogg@gmail.com \
--cc=claudio.fontana@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.