From: Vladimir Davydov <vdavydov@parallels.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: mhocko@suse.cz, rientjes@google.com, penberg@kernel.org,
cl@linux.com, glommer@gmail.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, devel@openvz.org,
Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH -mm v3 2/7] memcg, slab: cleanup memcg cache creation
Date: Sat, 22 Feb 2014 13:28:06 +0400 [thread overview]
Message-ID: <53086DA6.4090806@parallels.com> (raw)
In-Reply-To: <20140221161114.3025c658da0429b7ae9d4985@linux-foundation.org>
On 02/22/2014 04:11 AM, Andrew Morton wrote:
> On Thu, 20 Feb 2014 11:22:04 +0400 Vladimir Davydov <vdavydov@parallels.com> wrote:
>
>> This patch cleanups the memcg cache creation path as follows:
>> - Move memcg cache name creation to a separate function to be called
>> from kmem_cache_create_memcg(). This allows us to get rid of the
>> mutex protecting the temporary buffer used for the name formatting,
>> because the whole cache creation path is protected by the slab_mutex.
>> - Get rid of memcg_create_kmem_cache(). This function serves as a proxy
>> to kmem_cache_create_memcg(). After separating the cache name
>> creation path, it would be reduced to a function call, so let's
>> inline it.
> This patch makes a huge mess when it hits linux-next's e61734c5
> ("cgroup: remove cgroup->name"). In the vicinity of
> memcg_create_kmem_cache(). That isn't the first mess e61734c5 made :(
>
> I think I got it all fixed up - please check the end result in
> http://ozlabs.org/~akpm/stuff/.
It looks good to me, thank you!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Davydov <vdavydov@parallels.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: <mhocko@suse.cz>, <rientjes@google.com>, <penberg@kernel.org>,
<cl@linux.com>, <glommer@gmail.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>, <devel@openvz.org>,
Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH -mm v3 2/7] memcg, slab: cleanup memcg cache creation
Date: Sat, 22 Feb 2014 13:28:06 +0400 [thread overview]
Message-ID: <53086DA6.4090806@parallels.com> (raw)
In-Reply-To: <20140221161114.3025c658da0429b7ae9d4985@linux-foundation.org>
On 02/22/2014 04:11 AM, Andrew Morton wrote:
> On Thu, 20 Feb 2014 11:22:04 +0400 Vladimir Davydov <vdavydov@parallels.com> wrote:
>
>> This patch cleanups the memcg cache creation path as follows:
>> - Move memcg cache name creation to a separate function to be called
>> from kmem_cache_create_memcg(). This allows us to get rid of the
>> mutex protecting the temporary buffer used for the name formatting,
>> because the whole cache creation path is protected by the slab_mutex.
>> - Get rid of memcg_create_kmem_cache(). This function serves as a proxy
>> to kmem_cache_create_memcg(). After separating the cache name
>> creation path, it would be reduced to a function call, so let's
>> inline it.
> This patch makes a huge mess when it hits linux-next's e61734c5
> ("cgroup: remove cgroup->name"). In the vicinity of
> memcg_create_kmem_cache(). That isn't the first mess e61734c5 made :(
>
> I think I got it all fixed up - please check the end result in
> http://ozlabs.org/~akpm/stuff/.
It looks good to me, thank you!
next prev parent reply other threads:[~2014-02-22 9:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 7:22 [PATCH -mm v3 0/7] memcg-vs-slab related fixes, improvements, cleanups Vladimir Davydov
2014-02-20 7:22 ` Vladimir Davydov
2014-02-20 7:22 ` [PATCH -mm v3 1/7] memcg, slab: never try to merge memcg caches Vladimir Davydov
2014-02-20 7:22 ` Vladimir Davydov
2014-02-20 7:22 ` [PATCH -mm v3 2/7] memcg, slab: cleanup memcg cache creation Vladimir Davydov
2014-02-20 7:22 ` Vladimir Davydov
2014-02-22 0:11 ` Andrew Morton
2014-02-22 0:11 ` Andrew Morton
2014-02-22 9:28 ` Vladimir Davydov [this message]
2014-02-22 9:28 ` Vladimir Davydov
2014-02-20 7:22 ` [PATCH -mm v3 3/7] memcg, slab: separate memcg vs root cache creation paths Vladimir Davydov
2014-02-20 7:22 ` Vladimir Davydov
2014-02-20 7:22 ` [PATCH -mm v3 4/7] memcg, slab: unregister cache from memcg before starting to destroy it Vladimir Davydov
2014-02-20 7:22 ` Vladimir Davydov
2014-02-20 7:22 ` [PATCH -mm v3 5/7] memcg, slab: do not destroy children caches if parent has aliases Vladimir Davydov
2014-02-20 7:22 ` Vladimir Davydov
2014-02-20 7:22 ` [PATCH -mm v3 6/7] slub: adjust memcg caches when creating cache alias Vladimir Davydov
2014-02-20 7:22 ` Vladimir Davydov
2014-02-20 7:22 ` [PATCH -mm v3 7/7] slub: rework sysfs layout for memcg caches Vladimir Davydov
2014-02-20 7:22 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53086DA6.4090806@parallels.com \
--to=vdavydov@parallels.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=devel@openvz.org \
--cc=glommer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.