From: Daniel Borkmann <dborkman@redhat.com>
To: Tom Herbert <therbert@google.com>
Cc: Linux Netdev List <netdev@vger.kernel.org>,
Thomas Graf <tgraf@redhat.com>
Subject: Re: Does CHECKSUM_COMPLETE work at all?
Date: Sat, 22 Feb 2014 13:31:04 +0100 [thread overview]
Message-ID: <53089888.5020307@redhat.com> (raw)
In-Reply-To: <CA+mtBx8safaPpcntjqT+eUQBDEOxJBoVf-a9djX_qgYsSdACeA@mail.gmail.com>
On 02/22/2014 03:11 AM, Tom Herbert wrote:
> If a driver sets CHECKSUM_COMPLETE in a packet, I don't see anywhere
> in either the Ethernet rcv path or ip_rcv where the skb->csum is being
> pulled (no *pull_rcsum calls). I believe CHECKSUM_COMPLETE means the
> checksum is over the whole packet (L2, L3, and L4), so it looks like
> TCP would never see a usable value.
Funny you ask, we had recently similar question [1]. ;) So, yes, it
should be over the whole packet as seen by Linux, and is therefore not
usable as is by protocols like TCP.
[1] http://thread.gmane.org/gmane.linux.network/292443/
prev parent reply other threads:[~2014-02-22 12:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-22 2:11 Does CHECKSUM_COMPLETE work at all? Tom Herbert
2014-02-22 2:36 ` Dimitrios Michailidis
2014-02-22 3:08 ` Tom Herbert
2014-02-22 12:42 ` Daniel Borkmann
2014-02-22 17:32 ` Tom Herbert
2014-02-22 12:31 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53089888.5020307@redhat.com \
--to=dborkman@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=tgraf@redhat.com \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.