From: Daniel Borkmann <dborkman@redhat.com>
To: Tom Herbert <therbert@google.com>
Cc: Dimitrios Michailidis <dm@chelsio.com>,
Linux Netdev List <netdev@vger.kernel.org>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: Does CHECKSUM_COMPLETE work at all?
Date: Sat, 22 Feb 2014 13:42:28 +0100 [thread overview]
Message-ID: <53089B34.5060504@redhat.com> (raw)
In-Reply-To: <CA+mtBx97w02+6iVcDxsGh4-TzsnZcjRv0+jyD=qGrCPfcWNDqg@mail.gmail.com>
On 02/22/2014 04:08 AM, Tom Herbert wrote:
...
> Well..., I started trying to fix the UDP encapsulation code which we
> agreed was broken for checksums. This also entails fixing the new UDP
> GRO code to deal with checksums correctly when going through protocol
> layers. But, just looking at CHECKSUM_COMPLETE it seems like it's
> fundamentally broken even without encapsulation. Between GRO and HW
> checksums, it seems like we have a pretty big mess! :-)
Seems so, e.g. d97c00a32198 ("vxlan: fix receive checksum handling")
had similar issues in that regard; maybe because there seems to be
different consensus among drivers on setting CHECKSUM_COMPLETE?
next prev parent reply other threads:[~2014-02-22 12:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-22 2:11 Does CHECKSUM_COMPLETE work at all? Tom Herbert
2014-02-22 2:36 ` Dimitrios Michailidis
2014-02-22 3:08 ` Tom Herbert
2014-02-22 12:42 ` Daniel Borkmann [this message]
2014-02-22 17:32 ` Tom Herbert
2014-02-22 12:31 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53089B34.5060504@redhat.com \
--to=dborkman@redhat.com \
--cc=dm@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.