From: Milan Broz <gmazyland@gmail.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Tejun Heo <tj@kernel.org>, Mikulas Patocka <mpatocka@redhat.com>,
device-mapper development <dm-devel@redhat.com>,
Lisa Du <chunlingdu1@gmail.com>,
"Alasdair G. Kergon" <agk@redhat.com>
Subject: Re: dm-crypt: remove per-cpu structure
Date: Sat, 22 Feb 2014 19:58:04 +0100 [thread overview]
Message-ID: <5308F33C.5080405@gmail.com> (raw)
In-Reply-To: <20140222182907.GA13445@redhat.com>
On 02/22/2014 07:29 PM, Mike Snitzer wrote:
> Thanks for the configuration scenarios. I think I've asked this of you
> before but: Do you have any automated testing? Something that we hand a
> blockdevice to and it produces a result that you find meaningful to use
> as a point of comparison.
Ask Ondra, he should have all code what I used (I think he modified it later).
(It was some fio scripts, stacked dmcrypt test, some basic dt and fsx tests and
some simple seek test.)
I run it against several versions (no patch, without sort part, etc)
and tried to compare times and throughput.
It is of course possible I did some stupid mistake.
On top of it, I do not have anything better.
And I do not have any suitable hw for testing now, so I can just say my opinion.
I just hope you have more facts than you mentioned here to support your decision
to merge these changes.
Milan
next prev parent reply other threads:[~2014-02-22 18:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 23:01 [PATCH] dm-crypt: remove per-cpu structure Mikulas Patocka
2014-02-20 23:59 ` Mike Snitzer
2014-02-21 0:10 ` Mikulas Patocka
2014-02-21 2:32 ` Mike Snitzer
2014-02-21 7:41 ` Mikulas Patocka
2014-02-22 10:28 ` Milan Broz
2014-02-22 14:25 ` Mike Snitzer
2014-02-22 17:34 ` Milan Broz
2014-02-22 18:29 ` Mike Snitzer
2014-02-22 18:58 ` Milan Broz [this message]
2014-02-27 1:12 ` Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5308F33C.5080405@gmail.com \
--to=gmazyland@gmail.com \
--cc=agk@redhat.com \
--cc=chunlingdu1@gmail.com \
--cc=dm-devel@redhat.com \
--cc=mpatocka@redhat.com \
--cc=snitzer@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.