* [PATCH 1/1] ARM: exynos_defconfig: Fix a config option
@ 2013-12-27 10:38 Sachin Kamat
2014-02-24 0:21 ` Kukjin Kim
0 siblings, 1 reply; 3+ messages in thread
From: Sachin Kamat @ 2013-12-27 10:38 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: kgene.kim, sachin.kamat, patches
CONFIG_MACH_EXYNOS4_DT does not exist. Use ARCH_EXYNOS4 instead.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
arch/arm/configs/exynos_defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
index dbe1f1c47bb0..dff01ecf78cc 100644
--- a/arch/arm/configs/exynos_defconfig
+++ b/arch/arm/configs/exynos_defconfig
@@ -10,8 +10,8 @@ CONFIG_PARTITION_ADVANCED=y
CONFIG_ARCH_EXYNOS=y
CONFIG_S3C_LOWLEVEL_UART_PORT=3
CONFIG_S3C24XX_PWM=y
+CONFIG_ARCH_EXYNOS4=y
CONFIG_ARCH_EXYNOS5=y
-CONFIG_MACH_EXYNOS4_DT=y
CONFIG_SMP=y
CONFIG_NR_CPUS=8
CONFIG_PREEMPT=y
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] ARM: exynos_defconfig: Fix a config option
2013-12-27 10:38 [PATCH 1/1] ARM: exynos_defconfig: Fix a config option Sachin Kamat
@ 2014-02-24 0:21 ` Kukjin Kim
2014-03-04 12:23 ` Sachin Kamat
0 siblings, 1 reply; 3+ messages in thread
From: Kukjin Kim @ 2014-02-24 0:21 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-samsung-soc, kgene.kim, patches
On 12/27/13 19:38, Sachin Kamat wrote:
> CONFIG_MACH_EXYNOS4_DT does not exist. Use ARCH_EXYNOS4 instead.
>
> Signed-off-by: Sachin Kamat<sachin.kamat@linaro.org>
> ---
> arch/arm/configs/exynos_defconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index dbe1f1c47bb0..dff01ecf78cc 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -10,8 +10,8 @@ CONFIG_PARTITION_ADVANCED=y
> CONFIG_ARCH_EXYNOS=y
> CONFIG_S3C_LOWLEVEL_UART_PORT=3
> CONFIG_S3C24XX_PWM=y
> +CONFIG_ARCH_EXYNOS4=y
> CONFIG_ARCH_EXYNOS5=y
> -CONFIG_MACH_EXYNOS4_DT=y
> CONFIG_SMP=y
> CONFIG_NR_CPUS=8
> CONFIG_PREEMPT=y
Well, this is not required because it should be fine without this
change. ARCH_EXYNOS4 will be selected when ARCH_EXYNOS is enabled and
non-exist CONFIG (MACH_EXYNOS4_DT) will be ignored.
Thanks,
Kukjin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] ARM: exynos_defconfig: Fix a config option
2014-02-24 0:21 ` Kukjin Kim
@ 2014-03-04 12:23 ` Sachin Kamat
0 siblings, 0 replies; 3+ messages in thread
From: Sachin Kamat @ 2014-03-04 12:23 UTC (permalink / raw)
To: Kukjin Kim; +Cc: linux-samsung-soc
On 24 February 2014 05:51, Kukjin Kim <kgene.kim@samsung.com> wrote:
> On 12/27/13 19:38, Sachin Kamat wrote:
>>
>> CONFIG_MACH_EXYNOS4_DT does not exist. Use ARCH_EXYNOS4 instead.
>>
>> Signed-off-by: Sachin Kamat<sachin.kamat@linaro.org>
>> ---
>> arch/arm/configs/exynos_defconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/configs/exynos_defconfig
>> b/arch/arm/configs/exynos_defconfig
>> index dbe1f1c47bb0..dff01ecf78cc 100644
>> --- a/arch/arm/configs/exynos_defconfig
>> +++ b/arch/arm/configs/exynos_defconfig
>> @@ -10,8 +10,8 @@ CONFIG_PARTITION_ADVANCED=y
>> CONFIG_ARCH_EXYNOS=y
>> CONFIG_S3C_LOWLEVEL_UART_PORT=3
>> CONFIG_S3C24XX_PWM=y
>> +CONFIG_ARCH_EXYNOS4=y
>> CONFIG_ARCH_EXYNOS5=y
>> -CONFIG_MACH_EXYNOS4_DT=y
>> CONFIG_SMP=y
>> CONFIG_NR_CPUS=8
>> CONFIG_PREEMPT=y
>
>
> Well, this is not required because it should be fine without this change.
> ARCH_EXYNOS4 will be selected when ARCH_EXYNOS is enabled and non-exist
> CONFIG (MACH_EXYNOS4_DT) will be ignored.
Functionally this might not be needed as Exynos4 is selected by
default. However, I don't see
any point in retaining non-existent symbols.
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-04 12:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-27 10:38 [PATCH 1/1] ARM: exynos_defconfig: Fix a config option Sachin Kamat
2014-02-24 0:21 ` Kukjin Kim
2014-03-04 12:23 ` Sachin Kamat
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.