From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Gerd Hoffmann <kraxel@redhat.com>,
Anthony Liguori <aliguori@amazon.com>,
Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [Qemu-devel] [PATCH 6/9] w32: Add and use intermediate include file for windows.h
Date: Mon, 24 Feb 2014 11:26:46 +0100 [thread overview]
Message-ID: <530B1E66.8080200@redhat.com> (raw)
In-Reply-To: <1393174935-11750-7-git-send-email-sw@weilnetz.de>
Il 23/02/2014 18:02, Stefan Weil ha scritto:
> diff --git a/qga/channel-win32.c b/qga/channel-win32.c
> index 8a303f3..3a0bf13 100644
> --- a/qga/channel-win32.c
> +++ b/qga/channel-win32.c
> @@ -2,7 +2,7 @@
> #include <stdio.h>
> #include <stdbool.h>
> #include <glib.h>
> -#include <windows.h>
> +#include "sysemu/os-winapi.h"
> #include <errno.h>
> #include <io.h>
> #include "qga/guest-agent-core.h"
qga/ is not supposed to include include/sysemu (which is just for
qemu-system-*). I guess you can call the new file include/qemu/winapi.h
Paolo
next prev parent reply other threads:[~2014-02-24 10:27 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-23 17:02 [Qemu-devel] [PATCH 0/9] w32: Reduce dependency on Windows API Stefan Weil
2014-02-23 17:02 ` [Qemu-devel] [PATCH 1/9] util/iov: Use qemu/sockets.h instead of conditional code Stefan Weil
2014-02-23 17:02 ` [Qemu-devel] [PATCH 2/9] exec: Remove unneeded include files Stefan Weil
2014-02-23 17:02 ` [Qemu-devel] [PATCH 3/9] qemu-img: " Stefan Weil
2014-02-23 17:02 ` [Qemu-devel] [PATCH 4/9] qga: Remove unneeded include file Stefan Weil
2014-02-23 17:02 ` [Qemu-devel] [PATCH 5/9] vl: " Stefan Weil
2014-02-23 17:02 ` [Qemu-devel] [PATCH 6/9] w32: Add and use intermediate include file for windows.h Stefan Weil
2014-02-24 10:26 ` Paolo Bonzini [this message]
2014-02-24 23:00 ` Stefan Weil
2014-02-25 8:18 ` Paolo Bonzini
2014-02-23 17:02 ` [Qemu-devel] [PATCH 7/9] w32: Move inline function from header file to C source Stefan Weil
2014-02-23 17:02 ` [Qemu-devel] [PATCH 8/9] w32: Reduce dependencies in sysemu/os-win32.h Stefan Weil
2014-02-24 0:45 ` Max Filippov
2014-02-23 17:02 ` [Qemu-devel] [PATCH 9/9] w32: Replace Windows specific data types in common header files Stefan Weil
2014-02-24 10:17 ` Kevin Wolf
2014-02-24 13:24 ` Peter Maydell
2014-02-24 13:44 ` Kevin Wolf
2014-02-24 13:51 ` Peter Maydell
2014-02-24 23:12 ` Stefan Weil
2014-02-24 23:17 ` Stefan Weil
2014-02-24 13:07 ` Andreas Färber
2014-02-24 23:07 ` Stefan Weil
2014-02-25 8:37 ` Andreas Färber
2014-02-26 6:14 ` Stefan Weil
2014-02-27 15:45 ` Stefan Hajnoczi
2014-02-25 5:32 ` [Qemu-trivial] [Qemu-devel] [PATCH 0/9] w32: Reduce dependency on Windows API Stefan Weil
2014-02-25 5:32 ` Stefan Weil
2014-02-25 8:20 ` [Qemu-trivial] " Paolo Bonzini
2014-02-25 8:20 ` [Qemu-devel] " Paolo Bonzini
2014-02-25 8:40 ` [Qemu-trivial] " Andreas Färber
2014-02-25 8:40 ` Andreas Färber
2014-03-02 13:31 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530B1E66.8080200@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@amazon.com \
--cc=jan.kiszka@siemens.com \
--cc=kraxel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.