All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
	Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-trivial] [PATCH 0/9] w32: Reduce dependency on Windows API
Date: Tue, 25 Feb 2014 09:20:53 +0100	[thread overview]
Message-ID: <530C5265.4040900@redhat.com> (raw)
In-Reply-To: <530C2AE2.1010003@weilnetz.de>

Il 25/02/2014 06:32, Stefan Weil ha scritto:
> Am 23.02.2014 18:02, schrieb Stefan Weil:
>> Today, most .o files depend on windows.h when QEMU is built with MinGW or
>> MinGW-w64 (32 and 64 bit builds). These patches reduce the number of such
>> files from more than 1800 to less than 180. They also allow removing some
>> hacks which were needed because of conflicts with windows.h. A nasty
>> compiler warning is fixed, too.
>>
>> The modifications were tested with MinGW (32 bit native) and MinGW-w64
>> (32 and 64 bit cross).
>>
>> Regards
>> Stefan W.
>>
>> [PATCH 1/9] util/iov: Use qemu/sockets.h instead of conditional code
>> [PATCH 2/9] exec: Remove unneeded include files
>> [PATCH 3/9] qemu-img: Remove unneeded include files
>> [PATCH 4/9] qga: Remove unneeded include file
>> [PATCH 5/9] vl: Remove unneeded include file
>> [PATCH 6/9] w32: Add and use intermediate include file for windows.h
>> [PATCH 7/9] w32: Move inline function from header file to C source
>> [PATCH 8/9] w32: Reduce dependencies in sysemu/os-win32.h
>> [PATCH 9/9] w32: Replace Windows specific data types in common
>>
>
> This patch series needs at least one more iteration with a v2.
>
> Patches 1-5 can be applied independently of the rest and are trivial, so
> maybe they can be applied by qemu-trivial, or I can send a pull request
> for only those patches as soon as they were reviewed. That would reduce
> the size of my v2 patch set.

Patches 1-5 are

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Thanks for all the effort you put in janitorial work, it's as thankless 
as it's useful!

Paolo



WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
	Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH 0/9] w32: Reduce dependency on Windows API
Date: Tue, 25 Feb 2014 09:20:53 +0100	[thread overview]
Message-ID: <530C5265.4040900@redhat.com> (raw)
In-Reply-To: <530C2AE2.1010003@weilnetz.de>

Il 25/02/2014 06:32, Stefan Weil ha scritto:
> Am 23.02.2014 18:02, schrieb Stefan Weil:
>> Today, most .o files depend on windows.h when QEMU is built with MinGW or
>> MinGW-w64 (32 and 64 bit builds). These patches reduce the number of such
>> files from more than 1800 to less than 180. They also allow removing some
>> hacks which were needed because of conflicts with windows.h. A nasty
>> compiler warning is fixed, too.
>>
>> The modifications were tested with MinGW (32 bit native) and MinGW-w64
>> (32 and 64 bit cross).
>>
>> Regards
>> Stefan W.
>>
>> [PATCH 1/9] util/iov: Use qemu/sockets.h instead of conditional code
>> [PATCH 2/9] exec: Remove unneeded include files
>> [PATCH 3/9] qemu-img: Remove unneeded include files
>> [PATCH 4/9] qga: Remove unneeded include file
>> [PATCH 5/9] vl: Remove unneeded include file
>> [PATCH 6/9] w32: Add and use intermediate include file for windows.h
>> [PATCH 7/9] w32: Move inline function from header file to C source
>> [PATCH 8/9] w32: Reduce dependencies in sysemu/os-win32.h
>> [PATCH 9/9] w32: Replace Windows specific data types in common
>>
>
> This patch series needs at least one more iteration with a v2.
>
> Patches 1-5 can be applied independently of the rest and are trivial, so
> maybe they can be applied by qemu-trivial, or I can send a pull request
> for only those patches as soon as they were reviewed. That would reduce
> the size of my v2 patch set.

Patches 1-5 are

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Thanks for all the effort you put in janitorial work, it's as thankless 
as it's useful!

Paolo

  reply	other threads:[~2014-02-25  8:21 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-23 17:02 [Qemu-devel] [PATCH 0/9] w32: Reduce dependency on Windows API Stefan Weil
2014-02-23 17:02 ` [Qemu-devel] [PATCH 1/9] util/iov: Use qemu/sockets.h instead of conditional code Stefan Weil
2014-02-23 17:02 ` [Qemu-devel] [PATCH 2/9] exec: Remove unneeded include files Stefan Weil
2014-02-23 17:02 ` [Qemu-devel] [PATCH 3/9] qemu-img: " Stefan Weil
2014-02-23 17:02 ` [Qemu-devel] [PATCH 4/9] qga: Remove unneeded include file Stefan Weil
2014-02-23 17:02 ` [Qemu-devel] [PATCH 5/9] vl: " Stefan Weil
2014-02-23 17:02 ` [Qemu-devel] [PATCH 6/9] w32: Add and use intermediate include file for windows.h Stefan Weil
2014-02-24 10:26   ` Paolo Bonzini
2014-02-24 23:00     ` Stefan Weil
2014-02-25  8:18       ` Paolo Bonzini
2014-02-23 17:02 ` [Qemu-devel] [PATCH 7/9] w32: Move inline function from header file to C source Stefan Weil
2014-02-23 17:02 ` [Qemu-devel] [PATCH 8/9] w32: Reduce dependencies in sysemu/os-win32.h Stefan Weil
2014-02-24  0:45   ` Max Filippov
2014-02-23 17:02 ` [Qemu-devel] [PATCH 9/9] w32: Replace Windows specific data types in common header files Stefan Weil
2014-02-24 10:17   ` Kevin Wolf
2014-02-24 13:24     ` Peter Maydell
2014-02-24 13:44       ` Kevin Wolf
2014-02-24 13:51         ` Peter Maydell
2014-02-24 23:12           ` Stefan Weil
2014-02-24 23:17     ` Stefan Weil
2014-02-24 13:07   ` Andreas Färber
2014-02-24 23:07     ` Stefan Weil
2014-02-25  8:37       ` Andreas Färber
2014-02-26  6:14         ` Stefan Weil
2014-02-27 15:45   ` Stefan Hajnoczi
2014-02-25  5:32 ` [Qemu-trivial] [Qemu-devel] [PATCH 0/9] w32: Reduce dependency on Windows API Stefan Weil
2014-02-25  5:32   ` Stefan Weil
2014-02-25  8:20   ` Paolo Bonzini [this message]
2014-02-25  8:20     ` Paolo Bonzini
2014-02-25  8:40     ` [Qemu-trivial] " Andreas Färber
2014-02-25  8:40       ` Andreas Färber
2014-03-02 13:31 ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=530C5265.4040900@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.