From: George Dunlap <george.dunlap@eu.citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xensource.com
Cc: Ian Campbell <Ian.Campbell@citrix.com>,
M A Young <m.a.young@durham.ac.uk>
Subject: Re: [PATCH] tools/console: reset tty when xenconsole fails
Date: Mon, 24 Feb 2014 16:17:10 +0000 [thread overview]
Message-ID: <530B7086.2010309@eu.citrix.com> (raw)
In-Reply-To: <1393255564-3474-1-git-send-email-ian.jackson@eu.citrix.com>
On 02/24/2014 03:26 PM, Ian Jackson wrote:
> If xenconsole (the client program) fails, it calls err. This would
> previously neglect to reset the user's terminal to sanity. Use atexit
> to do so.
>
> This routinely happens in Xen 4.4 RC5 with pygrub because something
> writes the value "" to the tty xenstore key when using xenconsole.
> The cause of this is not yet known, but after this patch it just
> results in a harmless error message.
>
> Reported-by: M A Young <m.a.young@durham.ac.uk>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
I'm pretty sure this has been here for quite a while -- possibly since
4.3. I've been working around it for some time, at any rate. :-) So I
think at this point we should save this for 4.4.1.
-George
next prev parent reply other threads:[~2014-02-24 16:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 14:19 [PATCH 0/3] libxl: Fix deadlock with pygrub Ian Jackson
2014-02-24 14:19 ` [PATCH 1/3] libxl: Fix libxl_postfork_child_noexec deadlock etc Ian Jackson
2014-02-24 14:45 ` Ian Campbell
2014-02-24 14:53 ` M A Young
2014-02-24 14:55 ` Ian Campbell
2014-02-24 15:26 ` [PATCH] tools/console: reset tty when xenconsole fails Ian Jackson
2014-02-24 15:42 ` Ian Campbell
2014-02-24 16:17 ` George Dunlap [this message]
2014-02-24 15:17 ` [PATCH 1/3] libxl: Fix libxl_postfork_child_noexec deadlock etc George Dunlap
2014-02-24 15:47 ` George Dunlap
2014-02-24 15:49 ` George Dunlap
2014-02-25 5:17 ` Jim Fehlig
2014-02-25 13:32 ` Ian Jackson
2014-02-27 17:05 ` Jim Fehlig
2014-02-27 17:08 ` George Dunlap
2014-02-24 15:56 ` Ian Jackson
2014-02-24 16:28 ` George Dunlap
2014-02-24 17:09 ` Ian Jackson
2014-02-24 14:19 ` [PATCH 2/3] libxl: Hold the atfork lock while closing carefd Ian Jackson
2014-02-24 14:47 ` Ian Campbell
2014-02-24 14:19 ` [PATCH 3/3] libxl: Fix carefd lock leak in save callout Ian Jackson
2014-02-24 14:48 ` Ian Campbell
2014-02-24 14:49 ` [PATCH 0/3] libxl: Fix deadlock with pygrub Ian Campbell
2014-04-04 15:06 ` Ian Jackson
2014-03-13 13:59 ` Ian Campbell
2014-03-13 18:09 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530B7086.2010309@eu.citrix.com \
--to=george.dunlap@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=m.a.young@durham.ac.uk \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.