All of lore.kernel.org
 help / color / mirror / Atom feed
From: ZhangZhen <zhenzhang.zhang@huawei.com>
To: Wang Shilong <wangsl.fnst@cn.fujitsu.com>
Cc: <xfs@oss.sgi.com>, <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH for xfstests] xfstests: fix to make tests/btrfs/013 really work
Date: Tue, 25 Feb 2014 10:08:12 +0800	[thread overview]
Message-ID: <530BFB0C.7080602@huawei.com> (raw)
In-Reply-To: <530B26C9.9060606@cn.fujitsu.com>

Hi Wang,
Thank you for reviewing my patch.

I ran the test using btrfs progs v0.19(OpenSuse 12.3) previously and got a fail situation.
I verified v3.12 this morning and it work well as you mentioned.

Althouth the new version doesn't have this problem, I think it would be better to fix this.
I'll fix the titile and resend it.

On 2014/2/24 19:02, Wang Shilong wrote:
> Hi Zhang,
> 
> On 02/24/2014 06:51 PM, ZhangZhen wrote:
>> The test 013 couldn't work because here lacked "start".
>> This patch fix it.
>>
>> Signed-off-by: Zhang Zhen<zhenzhang.zhang@huawei.com>
>> ---
>>   tests/btrfs/013 | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/btrfs/013 b/tests/btrfs/013
>> index 7620fcc..fb81663 100644
>> --- a/tests/btrfs/013
>> +++ b/tests/btrfs/013
>> @@ -72,7 +72,7 @@ _check_csum_error()
>>   }
>>   $XFS_IO_PROG -f -c "falloc 0 1M" -c "pwrite 16k 8k" -c "fsync" \
>>       $SCRATCH_MNT/foo > $seqres.full 2>&1
>> -$BTRFS_UTIL_PROG filesystem balance $SCRATCH_MNT >> $seqres.full 2>&1 || \
>> +$BTRFS_UTIL_PROG filesystem balance start $SCRATCH_MNT >> $seqres.full 2>&1 || \
>>       _fail "balance failed"
> Due to historical reasons, we have 'btrfs file balance <>'.. Until now, it is also
> ok to run 'btrfs file balance <mnt>', and it has equal effect as 'btrfs filesystem balance start'.
> 
> Anyway, using latest 'btrfs file balance start <mnt>' is better than previous codes..but patch's
> title is not right any more...
> 
> BTW,Dave Chinner previously pointed out that we need a cleanup, url can be seen:
> 
> http://oss.sgi.com/archives/xfs/2014-02/msg00482.html
> 
> Thanks,
> Wang
>>   _scratch_unmount
>>   _scratch_mount
> 
> 
> 



WARNING: multiple messages have this Message-ID (diff)
From: ZhangZhen <zhenzhang.zhang@huawei.com>
To: Wang Shilong <wangsl.fnst@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH for xfstests] xfstests: fix to make tests/btrfs/013 really work
Date: Tue, 25 Feb 2014 10:08:12 +0800	[thread overview]
Message-ID: <530BFB0C.7080602@huawei.com> (raw)
In-Reply-To: <530B26C9.9060606@cn.fujitsu.com>

Hi Wang,
Thank you for reviewing my patch.

I ran the test using btrfs progs v0.19(OpenSuse 12.3) previously and got a fail situation.
I verified v3.12 this morning and it work well as you mentioned.

Althouth the new version doesn't have this problem, I think it would be better to fix this.
I'll fix the titile and resend it.

On 2014/2/24 19:02, Wang Shilong wrote:
> Hi Zhang,
> 
> On 02/24/2014 06:51 PM, ZhangZhen wrote:
>> The test 013 couldn't work because here lacked "start".
>> This patch fix it.
>>
>> Signed-off-by: Zhang Zhen<zhenzhang.zhang@huawei.com>
>> ---
>>   tests/btrfs/013 | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/btrfs/013 b/tests/btrfs/013
>> index 7620fcc..fb81663 100644
>> --- a/tests/btrfs/013
>> +++ b/tests/btrfs/013
>> @@ -72,7 +72,7 @@ _check_csum_error()
>>   }
>>   $XFS_IO_PROG -f -c "falloc 0 1M" -c "pwrite 16k 8k" -c "fsync" \
>>       $SCRATCH_MNT/foo > $seqres.full 2>&1
>> -$BTRFS_UTIL_PROG filesystem balance $SCRATCH_MNT >> $seqres.full 2>&1 || \
>> +$BTRFS_UTIL_PROG filesystem balance start $SCRATCH_MNT >> $seqres.full 2>&1 || \
>>       _fail "balance failed"
> Due to historical reasons, we have 'btrfs file balance <>'.. Until now, it is also
> ok to run 'btrfs file balance <mnt>', and it has equal effect as 'btrfs filesystem balance start'.
> 
> Anyway, using latest 'btrfs file balance start <mnt>' is better than previous codes..but patch's
> title is not right any more...
> 
> BTW,Dave Chinner previously pointed out that we need a cleanup, url can be seen:
> 
> http://oss.sgi.com/archives/xfs/2014-02/msg00482.html
> 
> Thanks,
> Wang
>>   _scratch_unmount
>>   _scratch_mount
> 
> 
> 


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2014-02-25  2:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <530AF3E3.9060202@huawei.com>
2014-02-24 10:51 ` [PATCH for xfstests] xfstests: fix to make tests/btrfs/013 really work ZhangZhen
2014-02-24 10:51   ` ZhangZhen
2014-02-24 11:02   ` Wang Shilong
2014-02-24 11:02     ` Wang Shilong
2014-02-25  2:08     ` ZhangZhen [this message]
2014-02-25  2:08       ` ZhangZhen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=530BFB0C.7080602@huawei.com \
    --to=zhenzhang.zhang@huawei.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wangsl.fnst@cn.fujitsu.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.