From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Baruch Siach <baruch@tkos.co.il>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
mark.rutland@arm.com, linux-samsung-soc@vger.kernel.org,
a.hajda@samsung.com, kyungmin.park@samsung.com,
robh+dt@kernel.org, galak@codeaurora.org, kgene.kim@samsung.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 04/10] V4L: Add driver for s5k6a3 image sensor
Date: Tue, 25 Feb 2014 14:37:17 +0100 [thread overview]
Message-ID: <530C9C8D.2040800@samsung.com> (raw)
In-Reply-To: <20140225095515.GV4869@tarshish>
On 25/02/14 10:55, Baruch Siach wrote:
> Thanks for the explanation. However, I've found no reference to the
> s5k6a3_sd_internal_ops struct in the driver code. There surly has to be at
> least one reference for the upper layer to access these ops.
There is indeed an assignment missing to sd->internal_ops in probe().
Thanks for spotting this, I've corrected that for next iteration.
--
Regards,
Sylwester
WARNING: multiple messages have this Message-ID (diff)
From: s.nawrocki@samsung.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 04/10] V4L: Add driver for s5k6a3 image sensor
Date: Tue, 25 Feb 2014 14:37:17 +0100 [thread overview]
Message-ID: <530C9C8D.2040800@samsung.com> (raw)
In-Reply-To: <20140225095515.GV4869@tarshish>
On 25/02/14 10:55, Baruch Siach wrote:
> Thanks for the explanation. However, I've found no reference to the
> s5k6a3_sd_internal_ops struct in the driver code. There surly has to be at
> least one reference for the upper layer to access these ops.
There is indeed an assignment missing to sd->internal_ops in probe().
Thanks for spotting this, I've corrected that for next iteration.
--
Regards,
Sylwester
next prev parent reply other threads:[~2014-02-25 13:37 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 17:35 [PATCH v5 00/10] Add device tree support for Exynos4 camera interface Sylwester Nawrocki
2014-02-24 17:35 ` Sylwester Nawrocki
2014-02-24 17:35 ` [PATCH v5 01/10] Documentation: dt: Add binding documentation for S5K6A3 image sensor Sylwester Nawrocki
2014-02-24 17:35 ` Sylwester Nawrocki
2014-02-24 17:35 ` [PATCH v5 02/10] Documentation: dt: Add binding documentation for S5C73M3 camera Sylwester Nawrocki
2014-02-24 17:35 ` Sylwester Nawrocki
2014-02-24 17:35 ` [PATCH v5 03/10] Documentation: devicetree: Update Samsung FIMC DT binding Sylwester Nawrocki
2014-02-24 17:35 ` Sylwester Nawrocki
2014-02-24 17:35 ` [PATCH v5 04/10] V4L: Add driver for s5k6a3 image sensor Sylwester Nawrocki
2014-02-24 17:35 ` Sylwester Nawrocki
2014-02-24 19:38 ` Baruch Siach
2014-02-24 19:38 ` Baruch Siach
2014-02-25 9:46 ` Sylwester Nawrocki
2014-02-25 9:46 ` Sylwester Nawrocki
2014-02-25 9:55 ` Baruch Siach
2014-02-25 9:55 ` Baruch Siach
2014-02-25 13:37 ` Sylwester Nawrocki [this message]
2014-02-25 13:37 ` Sylwester Nawrocki
2014-02-24 17:35 ` [PATCH v5 05/10] V4L: s5c73m3: Add device tree support Sylwester Nawrocki
2014-02-24 17:35 ` Sylwester Nawrocki
2014-02-24 17:35 ` [PATCH v5 06/10] exynos4-is: Use external s5k6a3 sensor driver Sylwester Nawrocki
2014-02-24 17:35 ` Sylwester Nawrocki
2014-02-24 17:35 ` [PATCH v5 07/10] exynos4-is: Add clock provider for the SCLK_CAM clock outputs Sylwester Nawrocki
2014-02-24 17:35 ` Sylwester Nawrocki
2014-02-24 17:35 ` [PATCH v5 08/10] exynos4-is: Add support for asynchronous subdevices registration Sylwester Nawrocki
2014-02-24 17:35 ` Sylwester Nawrocki
2014-02-24 17:35 ` [PATCH v5 09/10] ARM: dts: Add rear camera nodes for Exynos4412 TRATS2 board Sylwester Nawrocki
2014-02-24 17:35 ` Sylwester Nawrocki
2014-02-24 17:35 ` [PATCH v5 10/10] ARM: dts: exynos4: Update camera clk provider and s5k6a3 sensor node Sylwester Nawrocki
2014-02-24 17:35 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530C9C8D.2040800@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=a.hajda@samsung.com \
--cc=baruch@tkos.co.il \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.