From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
Xuebing Wang <xbing6@gmail.com>
Cc: "Blue Swirl" <blauwirbel@gmail.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH] translate: remove file translate-all.h
Date: Wed, 26 Feb 2014 11:34:14 +0100 [thread overview]
Message-ID: <530DC326.7020806@redhat.com> (raw)
In-Reply-To: <CAFEAcA-D5ciZVWZaBkf7YB_DmtgyxvraKTG=DTEXiUgtbeEQUA@mail.gmail.com>
Il 26/02/2014 10:55, Peter Maydell ha scritto:
> On 26 February 2014 09:25, Xuebing Wang <xbing6@gmail.com> wrote:
>> This patch does below:
>> - Move the declaration of 2 translate functions from translate-all.h into
>> include/exec/exec-all.h
>> - remove file translate-all.h
>>
>> "translate-all.h" => "exec/exec-all.h" can be done by:
>> git grep -w "translate-all.h" | cut -d: -f1 |
>> xargs sed -i 's/\<translate-all.h\>/exec\/exec-all.h/g'
>>
>> Note:
>> 1) "exact whole word match" is considered.
>> 2) We may move translate related from include/exec/exec-all.h into
>> include/exec/translate.h later.
>
> Is there any particular benefit to this change? The function
> prototypes go from being in a header only included by the file
> that uses them to being in a header that's included by a lot
> of other code...
Indeed, that's the point of translate-all.h.
Paolo
next prev parent reply other threads:[~2014-02-26 10:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 9:25 [Qemu-devel] [PATCH] translate: remove file translate-all.h Xuebing Wang
2014-02-26 9:55 ` Peter Maydell
2014-02-26 10:34 ` Paolo Bonzini [this message]
2014-02-26 12:19 ` Xuebing wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530DC326.7020806@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=blauwirbel@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=xbing6@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.