[PATCH v2] Enhance stripe size validation

[PATCH v2] Enhance stripe size validation

[Zhang Zhiqing]

From: Zhiqing Zhang <zhangzq.fnst@cn.fujitsu.com>

While stripe size is twice the physical extent size, the original code will not reduce stripe size to maximum(physical extent size).

Signed-off-by: Zhiqing Zhang <zhangzq.fnst@cn.fujitsu.com>
---
 lib/metadata/lv_manip.c |    2 +-
 man/lvresize.8.in       |    4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/lib/metadata/lv_manip.c b/lib/metadata/lv_manip.c
index 2b1cdcc..c791b6d 100644
--- a/lib/metadata/lv_manip.c
+++ b/lib/metadata/lv_manip.c
@@ -3394,7 +3394,7 @@ static int _validate_stripesize(struct cmd_context *cmd,
 
 	if (!(vg->fid->fmt->features & FMT_SEGMENTS))
 		log_warn("Varied stripesize not supported. Ignoring.");
-	else if (lp->ac_stripesize_value > (uint64_t) vg->extent_size * 2) {
+	else if (lp->ac_stripesize_value > (uint64_t) vg->extent_size) {
 		log_error("Reducing stripe size %s to maximum, "
 			  "physical extent size %s",
 			  display_size(cmd,lp->ac_stripesize_value),
diff --git a/man/lvresize.8.in b/man/lvresize.8.in
index 3606762..f746307 100644
--- a/man/lvresize.8.in
+++ b/man/lvresize.8.in
@@ -88,7 +88,9 @@ Defaults to whatever the last segment of the Logical Volume uses.
 Not applicable to LVs using the original metadata LVM format, which
 must use a single value throughout.
 .br
-StripeSize must be 2^n (n = 2 to 9).
+StripeSize must be 2^n (n = 2 to 9) for metadata in LVM1 format.
+For metadata in LVM2 format, the stripe size may be a larger
+power of 2 but must not exceed the physical extent size.
 .TP
 .B \-\-noudevsync
 Disable udev synchronisation. The
-- 
1.7.1

[PATCH v2] Enhance stripe size validation

[Zdenek Kabelac]

Dne 26.2.2014 03:14, Zhang Zhiqing napsal(a):
> From: Zhiqing Zhang <zhangzq.fnst@cn.fujitsu.com>
>
> While stripe size is twice the physical extent size, the original code will not reduce stripe size to maximum(physical extent size).
>

Yep thanks, applied with some more updates.

https://www.redhat.com/archives/lvm-devel/2014-February/msg00159.html

Unification of strip size validation is definitely needed....

Regards

Zdenek


> Signed-off-by: Zhiqing Zhang <zhangzq.fnst@cn.fujitsu.com>
> ---
>   lib/metadata/lv_manip.c |    2 +-
>   man/lvresize.8.in       |    4 +++-
>   2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/lib/metadata/lv_manip.c b/lib/metadata/lv_manip.c
> index 2b1cdcc..c791b6d 100644
> --- a/lib/metadata/lv_manip.c
> +++ b/lib/metadata/lv_manip.c
> @@ -3394,7 +3394,7 @@ static int _validate_stripesize(struct cmd_context *cmd,
>
>   	if (!(vg->fid->fmt->features & FMT_SEGMENTS))
>   		log_warn("Varied stripesize not supported. Ignoring.");
> -	else if (lp->ac_stripesize_value > (uint64_t) vg->extent_size * 2) {
> +	else if (lp->ac_stripesize_value > (uint64_t) vg->extent_size) {
>   		log_error("Reducing stripe size %s to maximum, "
>   			  "physical extent size %s",
>   			  display_size(cmd,lp->ac_stripesize_value),
> diff --git a/man/lvresize.8.in b/man/lvresize.8.in
> index 3606762..f746307 100644
> --- a/man/lvresize.8.in
> +++ b/man/lvresize.8.in
> @@ -88,7 +88,9 @@ Defaults to whatever the last segment of the Logical Volume uses.
>   Not applicable to LVs using the original metadata LVM format, which
>   must use a single value throughout.
>   .br
> -StripeSize must be 2^n (n = 2 to 9).
> +StripeSize must be 2^n (n = 2 to 9) for metadata in LVM1 format.
> +For metadata in LVM2 format, the stripe size may be a larger
> +power of 2 but must not exceed the physical extent size.
>   .TP
>   .B \-\-noudevsync
>   Disable udev synchronisation. The
>