From: Alexander Graf <agraf@suse.de>
To: Sven-Haegar Koch <haegar@sdinet.de>
Cc: Dave Hansen <dave.hansen@intel.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rik van Riel <riel@redhat.com>, Mel Gorman <mgorman@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>, Hugh Dickins <hughd@google.com>,
Izik Eidus <izik.eidus@ravellosystems.com>,
Andrea Arcangeli <aarcange@redhat.com>
Subject: Re: [PATCH] ksm: Expose configuration via sysctl
Date: Wed, 26 Feb 2014 18:32:08 +0100 [thread overview]
Message-ID: <530E2518.5090102@suse.de> (raw)
In-Reply-To: <alpine.DEB.2.10.1402261634010.31425@aurora64.sdinet.de>
Sven-Haegar Koch wrote:
> On Tue, 25 Feb 2014, Dave Hansen wrote:
>
>
>> On 02/25/2014 03:09 PM, Alexander Graf wrote:
>>
>>>> Couldn't we also (maybe in parallel) just teach the sysctl userspace
>>>> about sysfs? This way we don't have to do parallel sysctls and sysfs
>>>> for *EVERYTHING* in the kernel:
>>>>
>>>> sysfs.kernel.mm.transparent_hugepage.enabled=enabled
>>>>
>>> It's pretty hard to filter this. We definitely do not want to expose all of sysfs through /proc/sys. But how do we know which files are actual configuration and which ones are dynamic system introspection data?
>>>
>>> We could add a filter, but then we can just as well stick with the manual approach I followed here :).
>>>
>> Maybe not stick it under /proc/sys, but teach sysctl(8) about them. I
>> guess at the moment, sysctl says that it's tied to /proc/sys:
>>
>>
>>> DESCRIPTION
>>> sysctl is used to modify kernel parameters at runtime. The parameters available are those listed under /proc/sys/. Procfs is required
>>> for sysctl support in Linux. You can use sysctl to both read and write sysctl data.
>>>
>> But surely that's not set in stone just because the manpage says so. :)
>>
>
> What I still don't get is why you need this?
>
> My distribution (Debian) has a sysfsutils package which provides a
> /etc/sysfs.conf / /etc/sysfs.d/foo exactly like /etc/sysctl.conf.
>
> Don't other distributions have something like this?
>
Maybe that's the right answer to the problem, but I still don't
understand why these properties were put into sysfs in the first place.
We're not configuring a dynamic device here, are we?
Also if we do want something like a sysfs.conf and sysfs.d, that should
probably be something that gets properly coordinated between
distributions so that users don't get completely confused. Today
openSUSE does not have a sysfs.conf/.d provided by the sysfsutils
package. Maybe it's something homegrown?
Alex
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Graf <agraf@suse.de>
To: Sven-Haegar Koch <haegar@sdinet.de>
Cc: Dave Hansen <dave.hansen@intel.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rik van Riel <riel@redhat.com>, Mel Gorman <mgorman@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>, Hugh Dickins <hughd@google.com>,
Izik Eidus <izik.eidus@ravellosystems.com>,
Andrea Arcangeli <aarcange@redhat.com>
Subject: Re: [PATCH] ksm: Expose configuration via sysctl
Date: Wed, 26 Feb 2014 18:32:08 +0100 [thread overview]
Message-ID: <530E2518.5090102@suse.de> (raw)
In-Reply-To: <alpine.DEB.2.10.1402261634010.31425@aurora64.sdinet.de>
Sven-Haegar Koch wrote:
> On Tue, 25 Feb 2014, Dave Hansen wrote:
>
>
>> On 02/25/2014 03:09 PM, Alexander Graf wrote:
>>
>>>> Couldn't we also (maybe in parallel) just teach the sysctl userspace
>>>> about sysfs? This way we don't have to do parallel sysctls and sysfs
>>>> for *EVERYTHING* in the kernel:
>>>>
>>>> sysfs.kernel.mm.transparent_hugepage.enabled=enabled
>>>>
>>> It's pretty hard to filter this. We definitely do not want to expose all of sysfs through /proc/sys. But how do we know which files are actual configuration and which ones are dynamic system introspection data?
>>>
>>> We could add a filter, but then we can just as well stick with the manual approach I followed here :).
>>>
>> Maybe not stick it under /proc/sys, but teach sysctl(8) about them. I
>> guess at the moment, sysctl says that it's tied to /proc/sys:
>>
>>
>>> DESCRIPTION
>>> sysctl is used to modify kernel parameters at runtime. The parameters available are those listed under /proc/sys/. Procfs is required
>>> for sysctl support in Linux. You can use sysctl to both read and write sysctl data.
>>>
>> But surely that's not set in stone just because the manpage says so. :)
>>
>
> What I still don't get is why you need this?
>
> My distribution (Debian) has a sysfsutils package which provides a
> /etc/sysfs.conf / /etc/sysfs.d/foo exactly like /etc/sysctl.conf.
>
> Don't other distributions have something like this?
>
Maybe that's the right answer to the problem, but I still don't
understand why these properties were put into sysfs in the first place.
We're not configuring a dynamic device here, are we?
Also if we do want something like a sysfs.conf and sysfs.d, that should
probably be something that gets properly coordinated between
distributions so that users don't get completely confused. Today
openSUSE does not have a sysfs.conf/.d provided by the sysfsutils
package. Maybe it's something homegrown?
Alex
next prev parent reply other threads:[~2014-02-26 16:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 23:28 [PATCH] ksm: Expose configuration via sysctl Alexander Graf
2014-02-24 23:28 ` Alexander Graf
2014-02-25 12:33 ` Rik van Riel
2014-02-25 12:33 ` Rik van Riel
2014-02-25 17:15 ` Johannes Weiner
2014-02-25 17:15 ` Johannes Weiner
2014-02-25 17:19 ` Peter Zijlstra
2014-02-25 17:19 ` Peter Zijlstra
2014-02-25 23:16 ` Alexander Graf
2014-02-25 23:16 ` Alexander Graf
2014-02-25 23:50 ` Kay Sievers
2014-02-25 23:50 ` Kay Sievers
2014-02-26 1:05 ` Hugh Dickins
2014-02-26 1:05 ` Hugh Dickins
2014-02-26 7:49 ` Alexander Graf
2014-02-26 7:49 ` Alexander Graf
2014-02-25 17:34 ` Dave Hansen
2014-02-25 17:34 ` Dave Hansen
2014-02-25 23:09 ` Alexander Graf
2014-02-25 23:09 ` Alexander Graf
2014-02-26 0:10 ` Dave Hansen
2014-02-26 0:10 ` Dave Hansen
2014-02-26 15:36 ` Sven-Haegar Koch
2014-02-26 15:36 ` Sven-Haegar Koch
2014-02-26 17:32 ` Alexander Graf [this message]
2014-02-26 17:32 ` Alexander Graf
2014-02-26 0:02 ` Kay Sievers
2014-02-26 0:02 ` Kay Sievers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530E2518.5090102@suse.de \
--to=agraf@suse.de \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=haegar@sdinet.de \
--cc=hughd@google.com \
--cc=izik.eidus@ravellosystems.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.